fluidsynth: Update to version 2.5.0, fix checkver & autoupdate

[SorYoshino]

Summary

Updates fluidsynth to version 2.5.0 and restructures the manifest for better maintainability and accuracy.

Related issues or pull requests

• Relates to [email protected]: Add notes about DLLs #12056
• Relates to [Bug] Various packages stopped updating due to checkver errors #16379

Changes

• Updated version to 2.5.0
• Added 32bit architecture with explicit extract paths
• Introduced env_add_path instead of manual PATH modification instructions
• Improved license field with full SPDX and URL
• Updated checkver to use the GitHub API with JSONPath and regex for dynamic asset detection
• Reworked autoupdate logic to handle both x64 and x86 builds with flexible matching
• Refined description and homepage fields for consistency with other manifests

Notes

• Support for GLib and libinstpatch is hereby deprecated. They will be removed in 2.6.0.

• Starting from version 2.6.0, the related assets may revert to names like fluidsynth-2.x.y-win10-x64.zip and fluidsynth-2.x.y-win10-x86.zip. However, this change will not affect either the checkver or autoupdate functionality.

Testing

┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App fluidsynth -Dir "D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket" -f                
fluidsynth: 2.5.0 (scoop version is 2.5.0)
Forcing autoupdate!
Autoupdating fluidsynth
DEBUG[1761317365] [$updatedProperties] = [url extract_dir hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1761317365] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1761317365] $substitutions.$patchVersion                  0
DEBUG[1761317365] $substitutions.$majorVersion                  2
DEBUG[1761317365] $substitutions.$minorVersion                  5
DEBUG[1761317365] $substitutions.$basenameNoExt                 fluidsynth-v2.5.0-win10-x86-cpp11
DEBUG[1761317365] $substitutions.$url                           https://github.com/FluidSynth/fluidsynth/releases/download/v2.5.0/fluidsynth-v2.5.0-win10-x86-cpp11.zip
DEBUG[1761317365] $substitutions.$baseurl                       https://github.com/FluidSynth/fluidsynth/releases/download/v2.5.0
DEBUG[1761317365] $substitutions.$basename                      fluidsynth-v2.5.0-win10-x86-cpp11.zip
DEBUG[1761317365] $substitutions.$version                       2.5.0
DEBUG[1761317365] $substitutions.$matchTag                      v2.5.0
DEBUG[1761317365] $substitutions.$cleanVersion                  250
DEBUG[1761317365] $substitutions.$matchPrefix                   fluidsynth-v2.5.0-win10
DEBUG[1761317365] $substitutions.$matchTail
DEBUG[1761317365] $substitutions.$preReleaseVersion             2.5.0
DEBUG[1761317365] $substitutions.$dashVersion                   2-5-0
DEBUG[1761317365] $substitutions.$dotVersion                    2.5.0
DEBUG[1761317365] $substitutions.$match1                        2.5.0
DEBUG[1761317365] $substitutions.$buildVersion
DEBUG[1761317365] $substitutions.$underscoreVersion             2_5_0
DEBUG[1761317365] $substitutions.$matchSuffix                   -cpp11
DEBUG[1761317365] $substitutions.$urlNoExt                      https://github.com/FluidSynth/fluidsynth/releases/download/v2.5.0/fluidsynth-v2.5.0-win10-x86-cpp11
DEBUG[1761317365] $substitutions.$matchHead                     2.5.0
DEBUG[1761317365] $hashfile_url = $null -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
DEBUG[1761317367] $jsonpath = $..assets[?(@.browser_download_url == 'https://github.com/FluidSynth/fluidsynth/releases/download/v2.5.0/fluidsynth-v2.5.0-win10-x86-cpp11.zip')].digest -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:132:5
Found: beeee8609f457ed64be834d48091fa41e025ec93f9b0a4aff2efd195f22c7038 using Github Mode
... ...
Writing updated fluidsynth manifest

┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket][ fluidsynth ≢  ~1]
└─> scoop install .\fluidsynth.json
Installing 'fluidsynth' (2.5.0) [64bit] from 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket\fluidsynth.json'
Loading fluidsynth-v2.5.0-win10-x64-cpp11.zip from cache.
Checking hash of fluidsynth-v2.5.0-win10-x64-cpp11.zip ... ok.
Extracting fluidsynth-v2.5.0-win10-x64-cpp11.zip ... done.
Linking D:\Software\Scoop\Local\apps\fluidsynth\current => D:\Software\Scoop\Local\apps\fluidsynth\2.5.0
Adding D:\Software\Scoop\Local\apps\fluidsynth\current\bin to your path.
'fluidsynth' (2.5.0) was installed successfully!

• Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
• I have read the Contributing Guide

Summary by CodeRabbit

Release Notes

• Updates
  • FluidSynth upgraded to version 2.5.0 with enhanced SoundFont 2 software synthesizer capabilities
  • License information restructured for improved transparency
  • Installation and binary environment path handling modernized
  • Version checking mechanism improved for more reliable updates

[coderabbitai]

Walkthrough

Updates fluidsynth manifest from version 2.4.8 to 2.5.0, restructuring license field to an object format, replacing bin with env_add_path, updating checkver to GitHub API with jsonpath/regex patterns, and expanding autoupdate with per-architecture URL templates and extract directories.

Changes

Cohort / File(s)

Summary

FluidSynth manifest configuration bucket/fluidsynth.json

Version bumped to 2.5.0; license converted from string to structured object; bin field replaced with env_add_path; checkver migrated from GitHub repository reference to GitHub API endpoint with jsonpath and regex asset filtering; autoupdate expanded with per-architecture URL templates and extract_dir paths; architecture blocks updated with new v2.5.0 download URLs, explicit extract_dir specifications, and hash values; homepage URL trimmed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

• retroshare: Update to version 0.6.7.2, fix checkver & autoupdate, add 32bit version #16298: Applies similar manifest pattern updates including version bumps, architecture additions, and checkver/autoupdate GitHub API conversion with jsonpath/regex filtering.
• yesplaymusic: Update to version 0.4.10, fix checkver & autoupdate #16429: Matches identical schema transformations—license object conversion, checkver GitHub API migration, autoupdate per-architecture templating, and URL/hash updates.
• fontforge: Update to version 20251009, fix checkver & autoupdate, drop 32bit support #16343: Direct alignment on checkver (GitHub API + jsonpath/regex) and autoupdate (per-architecture templates) structural changes.

Suggested labels

review-needed

Suggested reviewers

• z-Fng

Poem

🐰✨ A synth takes flight from 2.4 to 2.5,
With manifests restructured, schemas alive,
License and paths in objects we trust,
JSON flows clean where GitHub APIs gust. 🎵

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The PR description comprehensively meets and exceeds the template requirements. It includes a clear summary of changes, properly references related issues (#12056 and #16379), provides detailed change documentation with bullet points covering all major modifications (version bump, 32-bit architecture, env_add_path, license improvements, checkver and autoupdate restructuring), includes important deprecation notes for future versions, and demonstrates thorough testing with complete testing output. Both required checkboxes are marked as completed, confirming the author has used the conventional PR title format and read the Contributing Guide.
Title Check	✅ Passed	The pull request title "fluidsynth: Update to version 2.5.0, fix checkver & autoupdate" directly corresponds to the primary changes in the changeset. The version bump from 2.4.8 to 2.5.0 is a major change, and the restructuring of checkver and autoupdate mechanisms are significant improvements highlighted in the PR objectives. The title is concise, specific, and uses proper formatting with the package name followed by clear descriptive language. It accurately summarizes the main changes without using vague terms or misleading information, though it appropriately omits secondary changes like 32-bit support, env_add_path implementation, and license improvements as those are supporting modifications rather than the primary focus.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

All changes look good.

Wait for review from human collaborators.

fluidsynth

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9eb6c7 and d459630.

📒 Files selected for processing (1)

• bucket/fluidsynth.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: WindowsPowerShell

🔇 Additional comments (3)

bucket/fluidsynth.json (3)

5-8: License field restructuring improves manifest clarity.

The migration from a string to a structured object with SPDX identifier and URL is a best-practice improvement that enhances maintainability and provides explicit license information.

---

27-38: Autoupdate template variables are correctly configured.

Verification confirms the template variables properly map to the checkver regex named capture groups:

• $matchTag correctly maps to (?<tag>v?([\\d.]+)) capturing "v2.5.0"
• $matchPrefix correctly maps to (?<prefix>[^\"]+) capturing "fluidsynth-v2.5.0-win10"
• $matchSuffix correctly maps to (?<suffix>-[^\"]+)? capturing "-cpp11"

URL template expansion produces the correct asset URLs for both architectures, and extract_dir values use consistent variable substitution. The configuration is valid.

---

10-19: extract_dir names verified as correct.

Both extract_dir values match the actual root folder names inside the ZIPs:

• 64-bit: fluidsynth-v2.5.0-win10-x64-cpp11/ ✓
• 32-bit: fluidsynth-v2.5.0-win10-x86-cpp11/ ✓

GitHub API confirmed the release assets exist with the expected names and sizes. Hash verification could not be completed in the sandbox environment due to SSL restrictions, but the file URLs and internal structure are correct. Hash integrity will be validated when users download these files.