[email protected]: Enhance checkver to prevent downgrades #15781
Conversation
|
Your changes do not pass checks. notepad3
|
|
Job failed for hitting API rate limit Should checkver and autoupdate move away from |
|
Hi. Any information? What is the purpose of this PR?
Not necessary IMO. |
some updates where not being picked up (IIRC typo in the release title), and the hash was always being calculated by the bot via the fallback path. So I wanted to dive into the mechanism to grok it.
👍 |
WalkthroughThe Notepad3 Scoop manifest updates its checkver mechanism to use the GitHub Releases API, adding a jsonpath to extract tag_name and retaining the regexp to derive the version. The checkver.url changes from the HTML releases page to the API’s latest release endpoint. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Scoop as Scoop (checkver)
participant GH as GitHub API
participant Parser as Parser
Scoop->>GH: GET /repos/rizonesoft/Notepad3/releases/latest
GH-->>Scoop: 200 OK (JSON: { tag_name, ... })
Note over Scoop,Parser: New step
Scoop->>Parser: Extract via jsonpath $.tag_name
Parser-->>Scoop: tag value (e.g., "v6.23.123.4")
Note over Scoop,Parser: Unchanged step
Scoop->>Parser: Apply regexp to tag to derive version
Parser-->>Scoop: version string
Scoop-->>Scoop: Update manifest version if changed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/notepad3.json (2)
57-59: Optional: simplify with GitHub shorthand.Scoop supports the “github” shorthand, avoiding jsonpath plumbing. Behavior remains the same.
- "url": "https://api.github.com/repos/rizonesoft/Notepad3/releases/latest", - "jsonpath": "$.tag_name", - "regex": "RELEASE([\\d.]+)" + "github": "rizonesoft/Notepad3", + "regex": "RELEASE_([\\d.]+)"
59-59: Optional: tighten the regex.Anchor to the full tag to avoid accidental partial matches if upstream changes naming.
- "regex": "RELEASE_([\\d.]+)" + "regex": "^RELEASE_([0-9.]+)$"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/notepad3.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (1)
bucket/notepad3.json (1)
57-59: Extraction verified; code changes approved
Extraction yields version 6.25.822.1 and asset URLs are correctly constructed—no further updates needed.
z-Fng
changed the title
z-Fng
changed the title
|
/verify. Rebased master. Enhance checkver to prevent downgrades: |
|
All changes look good. Wait for review from human collaborators. notepad3
|
Nice!
Cross referencing the date I think there was also an issue with RELEASE_6.25.714.1 |
Thank you for looking into this~ It seemed to be working well. The workflow picked up this version automatically a few hours after the release was published.
|
Thank you for closing that loop with the logs. It could have been just me doing things wrong, and stumbling into a fix... |
2 participants
To prevent downgrade like a1920db.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit