-
Notifications
You must be signed in to change notification settings - Fork 1.5k
tern-subtitle-file-translator: Update to version 5.3.7, fix checkver & autoupdate, improve notes #16430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tern-subtitle-file-translator: Update to version 5.3.7, fix checkver & autoupdate, improve notes #16430
Conversation
WalkthroughManifest updated: version 4.1.0 → 5.3.7; top-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. tern-subtitle-file-translator
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/tern-subtitle-file-translator.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/tern-subtitle-file-translator.json (3)
9-13: Excellent fix for previous shortcut creation error.The ASCII-only filename "Tern-Subtitle File Translator.exe" (replacing the problematic Chinese characters) correctly addresses the prior Windows shortcut creation failure ("Value does not fall within the expected range"). This resolves the issue reported in the previous review.
Also applies to: 20-20, 23-23
14-19: Version and architecture structure looks correct.The shift to an
architecture.64bitobject and updated URL/hash are well-formed. The hash format is valid (64 hex characters for SHA256) and matches the tested asset.
27-34: Capture group names are correctly mapped per Scoop's naming convention.The regex defines named groups
(?<tag>...)and(?<name>...), which map to$matchTagand$matchNamein autoupdate. This follows Scoop's documented convention where named capture groups have their first letter uppercased in the autoupdate placeholder.
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
This still doesn’t solve the problem of having multiple Perhaps we should temporarily put this PR on hold and merge it only after the issue is resolved in Scoop Core? |
|
|
Alright, thanks for your reply. |
Summary
Updates
tern-subtitle-file-translatorto version 5.3.7, improves metadata clarity, and enhances autoupdate reliability.Changes
notessection for clearer explanation of free usage vs. paid translation servicesWindows-win32-x64-5.3.7.ziphashto match the new release字幕机翻.exeautoupdateURL to match new release naming formatNote
Since the upstream
$.tag_nameand$.assets.namehave changed before, to avoid unnecessary maintenance in the future, this PR uses aregexto capture them.Testing
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit