-
Notifications
You must be signed in to change notification settings - Fork 1.5k
yesplaymusic: Update to version 0.4.10, fix checkver & autoupdate #16429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All changes look good. Wait for review from human collaborators. yesplaymusic
|
WalkthroughSingle Scoop bucket manifest update for YesPlayMusic, bumping version from 0.4.8-2 to 0.4.10, updating download URLs and hashes, converting license to a structured object, modernizing pre_install PowerShell syntax, and restructuring checkver/autoupdate to use GitHub API-based release discovery. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Updates
yesplaymusicto version 0.4.10, fixes outdated metadata, and improves autoupdate reliability.Changes
YesPlayMusic-Setup-0.4.10.exehashto use SHA512 for improved securitylicensemetadata and addedlicense.urllinking to the official MIT licensepre_installscript with safer parameters and broader cleanupcheckverto use the GitHub API withjsonpathfor more reliable version detectionautoupdatelogic to extract filenames dynamically and fetch hashes fromlatest.ymlNote
The upstream provides installer files in two naming formats:
YesPlayMusic-Setup-<version>.exeandYesPlayMusic.Setup.<version>.exe.To avoid unnecessary maintenance, this PR uses a
regexpattern to dynamically capture the correct filename.The
app-64.7zcontent inside the installer used in this PR is identical to that inside the installer of the original manifest. However, the new installer supports a more secure SHA512 hash verification.Testing
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Release Notes