Skip to content

Conversation

@SorYoshino
Copy link
Contributor

@SorYoshino SorYoshino commented Oct 9, 2025

Summary

This PR updates RetroShare to version 0.6.7.2 and adds the missing 32-bit architecture download.
It also fixes the checkver and autoupdate fields to correctly handle the GitHub release URLs.

Changes

  • Update version from 0.6.6 → 0.6.7.2
  • Add 32-bit architecture URLs and hashes
  • Update checkver to use GitHub API latest release
  • Improve regex to exclude -tor builds and handle -x64/-x86 variations
  • Update autoupdate to use $matchCommit instead of $version in filenames

Testing

  1. .\checkver.ps1 -App retroshare & scoop install retroshare
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App retroshare -Dir "D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket" -f 
retroshare: 0.6.7.2 (scoop version is 0.6.7.2)
Forcing autoupdate!
Autoupdating retroshare
DEBUG[1760021501] [$updatedProperties] = [hash url] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1760021501] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1760021501] $substitutions.$matchBuild                    20231126-Qt-5.15.2
DEBUG[1760021501] $substitutions.$majorVersion                  0
DEBUG[1760021501] $substitutions.$baseurl                       https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2
DEBUG[1760021501] $substitutions.$matchHead                     0.6.7
DEBUG[1760021501] $substitutions.$patchVersion                  7
DEBUG[1760021501] $substitutions.$basenameNoExt                 RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86
DEBUG[1760021501] $substitutions.$urlNoExt                      https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86
DEBUG[1760021501] $substitutions.$match1                        0.6.7.2
DEBUG[1760021501] $substitutions.$version                       0.6.7.2
DEBUG[1760021501] $substitutions.$basename                      RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86.7z
DEBUG[1760021501] $substitutions.$buildVersion                  2
DEBUG[1760021501] $substitutions.$matchCommit                   0.6.7a-4-ga1fdce2e5
DEBUG[1760021501] $substitutions.$matchTail                     .2
DEBUG[1760021501] $substitutions.$cleanVersion                  0672
DEBUG[1760021501] $substitutions.$underscoreVersion             0_6_7_2
DEBUG[1760021501] $substitutions.$preReleaseVersion             0.6.7.2
DEBUG[1760021501] $substitutions.$minorVersion                  6
DEBUG[1760021501] $substitutions.$dotVersion                    0.6.7.2
DEBUG[1760021501] $substitutions.$url                           https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86.7z
DEBUG[1760021501] $substitutions.$dashVersion                   0-6-7-2
DEBUG[1760021501] $hashfile_url = https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/chksums.txt -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
Searching hash for RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86.7z in https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/chksums.txt      
DEBUG[1760021503] $filenameRegex = ([a-fA-F0-9]{32,128})[\x20\t]+.*RetroShare-0\.6\.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5\.15\.2-x86\.7z(?:\s|$)|RetroShare-0\.6\.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5\.15\.2-x86\.7z[\x20\t]+.*?([a-fA-F0-9]{32,128}) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:99:13
Found: 23f2b5d31a495839ea8a511a72f71711bf260b80c6592c68f2f68a672fccd164 using Extract Mode
... ...
Writing updated retroshare manifest

┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket][ retroshare ≢  ~1]
└─> scoop install .\retroshare.json
Installing 'retroshare' (0.6.7.2) [64bit] from 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket\retroshare.json'
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |  %|path/URI
Download: ======+====+===========+===+===================================================
Download: 77e644|OK  |    56KiB/s|100|D:/Software/Scoop/Local/cache/retroshare#0.6.7.2#2f6bd32.7z
Download: Status Legend:
Download: (OK):download completed.
Checking hash of RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x64.7z ... ok.
Extracting RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x64.7z ... done.
Linking D:\Software\Scoop\Local\apps\retroshare\current => D:\Software\Scoop\Local\apps\retroshare\0.6.7.2
Creating shim for 'retroshare'.
Making D:\Software\Scoop\Local\shims\retroshare.exe a GUI binary.                                                       
Creating shim for 'retroshare-service'.
Creating shortcut for RetroShare (retroshare.exe)
Persisting Data
'retroshare' (0.6.7.2) was installed successfully!
Notes
-----
'retroshare-nogui' is replaced by 'retroshare-service' since version 0.6.6
See https://retroshareteam.wordpress.com/2021/03/15/release-notes-for-v0-6-6/ for details and instructions
  1. Regex correctly captures builds without -tor suffix
  • Use regex101 as the test site for the regular expression. Select the following content as the test URLs, which come from official repository releases of different versions, ending with " to simulate the result extracted using jsonpath.
https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x64-tor.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x64.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.7.2/RetroShare-0.6.7a-4-ga1fdce2e5-Windows-Portable-20231126-Qt-5.15.2-x86.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.6/RetroShare-0.6.6-Windows-Portable-20210313-0-g751fffc30-Qt-5.15.2-x64.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.5/RetroShare-0.6.5-Windows-Portable-20190204-1-gfb005f041-Qt-5.12.0-tor.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.5/RetroShare-0.6.5-Windows-Portable-20190204-1-gfb005f041-Qt-5.12.0.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.4/RetroShare-0.6.4-Windows-Portable-20180312-91634ba6-Qt-4.8.7.7z"

https://github.com/RetroShare/RetroShare/releases/download/v0.6.4/RetroShare-0.6.4-Windows-Portable-20180312-91634ba6-Qt-5.9.1.7z"
  • The test results are as follows:

2025-10-09 230119

Closes #14320

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Added 32-bit Windows Portable package support.
  • Chores

    • Updated RetroShare to version 0.6.7.2.
    • Switched update checks to use GitHub releases for more reliable detection.
    • Improved autoupdate to use commit-based identifiers for both 64-bit and 32-bit archives, aligning URLs with the latest release assets.

@coderabbitai
Copy link

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updates the RetroShare Scoop manifest to version 0.6.7.2, adds 32-bit Windows support, switches checkver to GitHub releases API with jsonpath filtering, updates regex to match commit/build identifiers, and revises autoupdate URLs to use commit-based identifiers for both architectures.

Changes

Cohort / File(s) Summary
Manifest update: version, architecture, autoupdate
bucket/retroshare.json
Bumped version to 0.6.7.2; replaced 64-bit URL/hash; added 32-bit Windows entry with URL/hash; changed checkver to GitHub API with jsonpath and new regex; updated autoupdate URLs to commit-based pattern for 64-bit and 32-bit; minor structural alignment in autoupdate block.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Scoop
  participant GitHubAPI as GitHub Releases API
  participant Manifest as retroshare.json

  User->>Scoop: scoop update retroshare
  Scoop->>Manifest: Load checkver config
  Scoop->>GitHubAPI: GET /repos/.../releases/latest
  GitHubAPI-->>Scoop: JSON (assets list)
  Scoop->>Scoop: jsonpath filter Windows-Portable assets
  Scoop->>Scoop: Regex parse commit/build identifiers
  Scoop->>Manifest: Apply autoupdate with commit-based URLs (x64/x86)
  Scoop-->>User: Reports new version 0.6.7.2 available
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

A hop, a skip—new bits to fetch,
Commit trails guide each tidy sketch.
x64, x86 now pair,
The carrots line the shelves with care.
I thump the ground: “0.6.7.2!”
Fresh downloads sprout—hurray, yahoo! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the key changes by specifying the version update, fixes to checkver and autoupdate, and addition of the 32-bit package in a concise, descriptive sentence.
Linked Issues Check ✅ Passed All core objectives from issue #14320 are addressed by bumping the version to 0.6.7.2, adding 32-bit binaries, configuring checkver to use the GitHub API, refining the regex to exclude “-tor” builds and handle x64/x86 suffixes, and updating autoupdate logic to use matchCommit instead of version.
Out of Scope Changes Check ✅ Passed All modifications directly relate to the linked issue requirements and there are no unrelated or extraneous changes in the manifest.
Description Check ✅ Passed The description follows the repository template by providing a summary, a detailed list of changes, testing instructions, a clear “Closes #14320” reference, and the required checklist items, making it largely complete and aligned with expectations.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

All changes look good.

Wait for review from human collaborators.

retroshare

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1beb178 and ccc133b.

📒 Files selected for processing (1)
  • bucket/retroshare.json (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.

@SorYoshino
Copy link
Contributor Author

Since I am not sure whether using 0.6.7 would affect future GitHub Actions updates for the manifest, and the repository's Tags contain multiple entries related to 0.6.7—with all assets prior to v0.6.7.2 having been deleted—I have used "version": "0.6.7.2" in the manifest.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Update]: Retroshare to 0.6.7

2 participants