-
Notifications
You must be signed in to change notification settings - Fork 1.5k
retroshare: Update to version 0.6.7.2, fix checkver & autoupdate, add 32bit version #16298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the RetroShare Scoop manifest to version 0.6.7.2, adds 32-bit Windows support, switches checkver to GitHub releases API with jsonpath filtering, updates regex to match commit/build identifiers, and revises autoupdate URLs to use commit-based identifiers for both architectures. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Scoop
participant GitHubAPI as GitHub Releases API
participant Manifest as retroshare.json
User->>Scoop: scoop update retroshare
Scoop->>Manifest: Load checkver config
Scoop->>GitHubAPI: GET /repos/.../releases/latest
GitHubAPI-->>Scoop: JSON (assets list)
Scoop->>Scoop: jsonpath filter Windows-Portable assets
Scoop->>Scoop: Regex parse commit/build identifiers
Scoop->>Manifest: Apply autoupdate with commit-based URLs (x64/x86)
Scoop-->>User: Reports new version 0.6.7.2 available
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. retroshare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/retroshare.json(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
|
Since I am not sure whether using |
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
This PR updates RetroShare to version 0.6.7.2 and adds the missing 32-bit architecture download.
It also fixes the
checkverandautoupdatefields to correctly handle the GitHub release URLs.Changes
versionfrom 0.6.6 → 0.6.7.2checkverto use GitHub API latest release-torbuilds and handle-x64/-x86variationsautoupdateto use$matchCommitinstead of$versionin filenamesTesting
.\checkver.ps1 -App retroshare&scoop install retroshare-torsuffix"to simulate the result extracted usingjsonpath.Closes #14320
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Chores