feat: Global header #35807
Merged
feat: Global header #35807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 25d6ee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
apps/meteor/client/NavBarV2/NavBarPagesToolbar/actions/CreateDirectMessage.tsx
Show resolved
Hide resolved
apps/meteor/client/NavBarV2/NavBarSettingsToolbar/NavBarItemAdministrationMenu.spec.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/NavBarV2/NavBarSettingsToolbar/hooks/useAuditMenu.tsx
Show resolved
Hide resolved
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35807 +/- ##
===========================================
+ Coverage 61.19% 61.26% +0.06%
===========================================
Files 2979 3149 +170
Lines 70982 74099 +3117
Branches 16208 16524 +316
===========================================
+ Hits 43438 45395 +1957
- Misses 24590 25657 +1067
- Partials 2954 3047 +93
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
force-pushed
the
feat/global-navigation
branch
from
182a9eb to
782d0d2
Compare
dougfabris
force-pushed
the
feat/global-navigation
branch
from
9f54d50 to
e8bc00c
Compare
juliajforesti
previously approved these changes
Apr 18, 2025
juliajforesti
previously approved these changes
Apr 18, 2025
juliajforesti
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
force-pushed
the
feat/global-navigation
branch
from
b4e49f8 to
4bf4aa3
Compare
dougfabris
force-pushed
the
feat/global-navigation
branch
from
7bfb32f to
8de3921
Compare
juliajforesti
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
Issue(s)
Steps to test or reproduce
Further comments
SIDE2-1
This pull request introduces a new global header feature to the Rocket.Chat application, focusing on enhancing the navigation experience. Key changes include:
NavBar Restructuring: The navigation bar (
NavBar.tsx) has been restructured to group related toolbar items more effectively using<NavBarSection>. New navigation items such asNavBarItemCreateNew,NavBarItemSort, andNavBarItemVoipTogglerhave been added, with updated imports and conditional rendering logic for VOIP and Omnichannel sections.Component and Hook Renaming: Several components and hooks have been renamed for clarity and consistency. For instance,
CreateRoomis nowNavBarItemCreateNew, and the hookuseCreateRoomMenuis renamed touseCreateNewMenu.Import Path Updates: Numerous files have had their import paths updated, reflecting a reorganization of the codebase. This includes components and hooks related to creating channels, direct messages, and teams.
Matrix Federation and VoIP Enhancements: The PR adds Matrix Federation functionality and refactors the VoIP toggle into a dedicated component (
NavBarItemVoipToggler), improving modularity.Administration Menu Updates: The
NavBarItemAdministrationMenucomponent now includes an audit section, with logic updates to determine the active state based on the current route. Tests have been added to ensure correct menu item display based on user permissions and license activation.Icon and UI Adjustments: The icon for the
NavBarItemVoipDialerhas been changed from 'phone' to 'dialpad' to better represent its functionality.Overall, this pull request focuses on improving the navigation structure, enhancing modularity, and ensuring consistency across the navigation components in the Rocket.Chat application.