Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 4, 2025

Proposed changes (including videos or screenshots)

Screenshot 2025-04-10 at 15 16 19

  • Reorganize actions in NavBar
  • Move VoIP toggle button from user menu to NavBar
  • Move Create new and Sort menu to NavBar
  • Move audit actions to admin settings menu

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-2
SIDE2-5

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 19d9d4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35707/

Built to branch gh-pages at 2025-04-11 12:18 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (a486016) to head (19d9d4a).
Report is 1 commits behind head on feat/global-navigation.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/global-navigation   #35707   +/-   ##
=======================================================
  Coverage                   59.62%   59.62%           
=======================================================
  Files                        2830     2830           
  Lines                       68297    68290    -7     
  Branches                    15134    15130    -4     
=======================================================
- Hits                        40719    40718    -1     
+ Misses                      24969    24963    -6     
  Partials                     2609     2609           
Flag Coverage Δ
unit 75.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review April 10, 2025 18:19
@dougfabris dougfabris requested a review from a team as a code owner April 10, 2025 18:19
@dougfabris dougfabris merged commit a7a2f20 into feat/global-navigation Apr 11, 2025
48 checks passed
@dougfabris dougfabris deleted the feat/navbar-pages-preferences branch April 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants