Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 17, 2025

Proposed changes (including videos or screenshots)

Kapture 2025-04-17 at 14 13 04

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-19
SIDE2-35

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 931141a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35835/

Built to branch gh-pages at 2025-04-18 00:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 42.59259% with 124 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (5702b7e) to head (931141a).
Report is 1 commits behind head on feat/global-navigation.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/global-navigation   #35835      +/-   ##
==========================================================
- Coverage                   60.99%   60.94%   -0.05%     
==========================================================
  Files                        3102     3115      +13     
  Lines                       73264    73366     +102     
  Branches                    16425    16445      +20     
==========================================================
+ Hits                        44685    44712      +27     
- Misses                      25545    25625      +80     
+ Partials                     3034     3029       -5     
Flag Coverage Δ
e2e 57.51% <42.59%> (-0.09%) ⬇️
unit 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review April 17, 2025 18:53
@dougfabris dougfabris requested a review from a team as a code owner April 17, 2025 18:53
@dougfabris dougfabris merged commit 4b8fd9b into feat/global-navigation Apr 18, 2025
48 checks passed
@dougfabris dougfabris deleted the feat/navbar-responsiveness branch April 18, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants