Skip to content

regression: Sidebar should collapse in tablet view under feature preview only #35872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Apr 28, 2025
Merged

regression: Sidebar should collapse in tablet view under feature preview only #35872

kodiakhq merged 3 commits into from
Apr 28, 2025

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 24, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Introduced here: #35807

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-66

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 84279ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 24, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 7.6.0 milestone Apr 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35872/

Built to branch gh-pages at 2025-04-28 17:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.14%. Comparing base (a083701) to head (84279ad).
Report is 14 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35872      +/-   ##
=================================================
- Coverage          61.16%   61.14%   -0.02%     
=================================================
  Files               3003     3003              
  Lines              71350    71352       +2     
  Branches           16333    16334       +1     
=================================================
- Hits               43638    43628      -10     
- Misses             24746    24757      +11     
- Partials            2966     2967       +1
Flag Coverage Δ
e2e 57.85% <100.00%> (-0.03%) ⬇️
unit 74.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris changed the title regression: Sidebar should collapse in tablet view only under feature preview regression: Sidebar should collapse in tablet view under feature preview only Apr 24, 2025
@dougfabris dougfabris marked this pull request as ready for review April 25, 2025 23:07
@dougfabris dougfabris requested a review from a team as a code owner April 25, 2025 23:07
aleksandernsilva
aleksandernsilva requested changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as expected ✅

Can we also add tests to cover this behavior?

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Apr 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 28, 2025
@aleksandernsilva aleksandernsilva removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Apr 28, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Apr 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 28, 2025
@kodiakhq kodiakhq bot merged commit 6f70529 into release-7.6.0 Apr 28, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the reg/sidebar-collapse branch April 28, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougfabris @aleksandernsilva