Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 14, 2025

Proposed changes (including videos or screenshots)

  • New navbar history navigation
  • New navbar channels search
  • Navbar focus order and tab steps improvements

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-4
SIDE2-47

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 51e7433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 63.47826% with 42 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (83107f5) to head (b7774cc).
Report is 1 commits behind head on feat/global-navigation.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/global-navigation   #35798      +/-   ##
==========================================================
- Coverage                   60.99%   60.96%   -0.03%     
==========================================================
  Files                        3098     3102       +4     
  Lines                       73240    73263      +23     
  Branches                    16412    16410       -2     
==========================================================
- Hits                        44673    44666       -7     
- Misses                      25545    25566      +21     
- Partials                     3022     3031       +9     
Flag Coverage Δ
e2e 57.55% <63.47%> (-0.06%) ⬇️
unit 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35798/

Built to branch gh-pages at 2025-04-15 22:18 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris force-pushed the feat/navbar-navigation-search branch from 219093f to 37b1359 Compare April 15, 2025 15:04
@dougfabris dougfabris force-pushed the feat/navbar-navigation-search branch from 211bafc to 852f876 Compare April 15, 2025 20:09
@dougfabris dougfabris force-pushed the feat/navbar-navigation-search branch from 852f876 to 51e7433 Compare April 15, 2025 21:49
@dougfabris dougfabris marked this pull request as ready for review April 15, 2025 22:00
@dougfabris dougfabris requested a review from a team as a code owner April 15, 2025 22:00
@dougfabris dougfabris merged commit 5702b7e into feat/global-navigation Apr 16, 2025
48 checks passed
@dougfabris dougfabris deleted the feat/navbar-navigation-search branch April 16, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants