-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: NavbarSearch closing list when clicking on field
#35909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.6.0 #35909 +/- ##
================================================
Coverage ? 61.22%
================================================
Files ? 3013
Lines ? 71528
Branches ? 16349
================================================
Hits ? 43790
Misses ? 24769
Partials ? 2969
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Introduced here: #35807
Issue(s)
Steps to test or reproduce
Further comments
SIDE2-68
This pull request addresses a regression issue in the Rocket.Chat application where the
NavbarSearchcomponent was closing its list when clicking on the search field. The changes include the addition of a click handler in theNavBarSearch.tsxfile to enhance user interaction. Additionally, a new hook,useSearchClick, has been introduced to manage the search click functionality and overlay state. These updates aim to improve the search experience in the navigation bar.