Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 29, 2025

Proposed changes (including videos or screenshots)

Introduced here: #35807

Kapture 2025-04-29 at 20 29 31

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-68


This pull request addresses a regression issue in the Rocket.Chat application where the NavbarSearch component was closing its list when clicking on the search field. The changes include the addition of a click handler in the NavBarSearch.tsx file to enhance user interaction. Additionally, a new hook, useSearchClick, has been introduced to manage the search click functionality and overlay state. These updates aim to improve the search experience in the navigation bar.

@dougfabris dougfabris added this to the 7.6.0 milestone Apr 29, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 29, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: 07112f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 29, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@dougfabris dougfabris changed the base branch from develop to release-7.6.0 April 29, 2025 23:09
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35909/

Built to branch gh-pages at 2025-04-29 23:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-7.6.0@527801b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.6.0   #35909   +/-   ##
================================================
  Coverage                 ?   61.22%           
================================================
  Files                    ?     3013           
  Lines                    ?    71528           
  Branches                 ?    16349           
================================================
  Hits                     ?    43790           
  Misses                   ?    24769           
  Partials                 ?     2969           
Flag Coverage Δ
e2e 57.87% <85.71%> (?)
unit 75.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review April 29, 2025 23:32
@dougfabris dougfabris requested a review from a team as a code owner April 29, 2025 23:32
@ggazzo ggazzo merged commit 81aede6 into release-7.6.0 Apr 30, 2025
52 of 54 checks passed
@ggazzo ggazzo deleted the regression/navbarList-open branch April 30, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants