Skip to content

chore: services changes on lifecycle methods + throw if svc is not available - #31375

Merged
sampaiodiego merged 3 commits into
developfrom
chore/meteor-3-changes-6
Jan 5, 2024
Merged

chore: services changes on lifecycle methods + throw if svc is not available#31375
sampaiodiego merged 3 commits into
developfrom
chore/meteor-3-changes-6

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Extracted from #29112

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 4, 2024 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0867ae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 4, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8677f15) 59.39% compared to head (0867ae4) 49.35%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31375       +/-   ##
============================================
- Coverage    59.39%   49.35%   -10.05%     
============================================
  Files         1793     3309     +1516     
  Lines        34909    81317    +46408     
  Branches      7246    16653     +9407     
============================================
+ Hits         20734    40130    +19396     
- Misses       12573    36485    +23912     
- Partials      1602     4702     +3100
Flag Coverage Δ
e2e 52.54% <ø> (-0.03%) ⬇️
e2e-api 40.65% <0.00%> (?)
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

sampaiodiego
sampaiodiego requested changes Jan 4, 2024
View reviewed changes
Comment thread packages/core-services/src/LocalBroker.ts Outdated
@MarcosSpessatto
MarcosSpessatto marked this pull request as ready for review January 5, 2024 09:59
@MarcosSpessatto
MarcosSpessatto requested a review from a team as a code owner January 5, 2024 09:59
@sampaiodiego
sampaiodiego merged commit bef7db1 into develop Jan 5, 2024
@sampaiodiego
sampaiodiego deleted the chore/meteor-3-changes-6 branch January 5, 2024 12:03
gabriellsh added a commit that referenced this pull request Jan 5, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
37fcb71 
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: add gitpod config file for quick setup (#30921)
  feat: Allow user to set timeout of outgoing webhook (#31222)
  feat: added modal confirmation before pinning message (#31348)
  fix: not being able to access or create rooms with join code (#31270)
  chore: services changes on lifecycle methods + throw if svc is not available (#31375)
  test: bump playwright (#31376)
  i18n: update translations (#29462)
  i18n: adds video call translations for Persian language (#30406)
  regression: `AppRow` bundleIn verification (#31373)
  feat: Add Desktop PDF viewer (#31279)
  fix: Attachments not collapsing when using incoming webhook (#31318)
  chore: add aria-label to Select Inputs at Engagement Dashboard (#31249)
  fix: engagement dashboard timezone selector (#31248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes
@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcosSpessatto @sampaiodiego