feat: Allow user to set timeout of outgoing webhook - #31222
Merged
kodiakhq[bot] merged 2 commits intoJan 5, 2024
Conversation
|
gracefulm
force-pushed
the
outgoing-webhook-timeout
branch
from
December 13, 2023 10:51
47238fd to
22d77fe
Compare
gracefulm
marked this pull request as ready for review
December 13, 2023 11:05
gracefulm
force-pushed
the
outgoing-webhook-timeout
branch
5 times, most recently
from
December 19, 2023 12:14
fbf0b19 to
101b4bd
Compare
gracefulm
force-pushed
the
outgoing-webhook-timeout
branch
from
December 28, 2023 07:16
1077b0f to
b5ebc9a
Compare
gracefulm
force-pushed
the
outgoing-webhook-timeout
branch
from
December 28, 2023 22:29
b5ebc9a to
4e7dc2e
Compare
gracefulm
force-pushed
the
outgoing-webhook-timeout
branch
from
January 5, 2024 06:27
4e7dc2e to
d9c81ed
Compare
pierre-lehnen-rc
approved these changes
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31222 +/- ##
===========================================
+ Coverage 49.35% 49.36% +0.01%
===========================================
Files 3311 3308 -3
Lines 81366 81326 -40
Branches 16661 16652 -9
===========================================
- Hits 40157 40147 -10
+ Misses 36506 36488 -18
+ Partials 4703 4691 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
added a commit
that referenced
this pull request
Jan 5, 2024
…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: chore: add gitpod config file for quick setup (#30921) feat: Allow user to set timeout of outgoing webhook (#31222) feat: added modal confirmation before pinning message (#31348) fix: not being able to access or create rooms with join code (#31270) chore: services changes on lifecycle methods + throw if svc is not available (#31375) test: bump playwright (#31376) i18n: update translations (#29462) i18n: adds video call translations for Persian language (#30406) regression: `AppRow` bundleIn verification (#31373) feat: Add Desktop PDF viewer (#31279) fix: Attachments not collapsing when using incoming webhook (#31318) chore: add aria-label to Select Inputs at Engagement Dashboard (#31249) fix: engagement dashboard timezone selector (#31248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Motivation
This change allows us to set the timeout as follows.
Issue(s)
Steps to test or reproduce
Further comments