Skip to content

feat: Add Desktop PDF viewer - #31279

Merged
kodiakhq[bot] merged 11 commits into
developfrom
poc-pdf
Jan 3, 2024
Merged

feat: Add Desktop PDF viewer#31279
kodiakhq[bot] merged 11 commits into
developfrom
poc-pdf

Conversation

@jeanfbrito

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 19, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d8c618d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (87bba6d) 49.31% compared to head (d8c618d) 49.34%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31279      +/-   ##
===========================================
+ Coverage    49.31%   49.34%   +0.02%     
===========================================
  Files         3302     3310       +8     
  Lines        81221    81343     +122     
  Branches     16637    16659      +22     
===========================================
+ Hits         40052    40136      +84     
- Misses       36474    36505      +31     
- Partials      4695     4702       +7     
Flag Coverage Δ
e2e 52.51% <50.00%> (+0.04%) ⬆️
e2e-api 40.65% <ø> (+0.01%) ⬆️
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jeanfbrito
jeanfbrito marked this pull request as ready for review December 29, 2023 20:06
@jeanfbrito
jeanfbrito requested a review from a team as a code owner December 29, 2023 20:06
@tassoevan tassoevan added this to the 6.6 milestone Jan 2, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 3, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 3, 2024
@kodiakhq
kodiakhq Bot merged commit 0da7423 into develop Jan 3, 2024
@kodiakhq
kodiakhq Bot deleted the poc-pdf branch January 3, 2024 19:35
gabriellsh added a commit that referenced this pull request Jan 5, 2024
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: add gitpod config file for quick setup (#30921)
  feat: Allow user to set timeout of outgoing webhook (#31222)
  feat: added modal confirmation before pinning message (#31348)
  fix: not being able to access or create rooms with join code (#31270)
  chore: services changes on lifecycle methods + throw if svc is not available (#31375)
  test: bump playwright (#31376)
  i18n: update translations (#29462)
  i18n: adds video call translations for Persian language (#30406)
  regression: `AppRow` bundleIn verification (#31373)
  feat: Add Desktop PDF viewer (#31279)
  fix: Attachments not collapsing when using incoming webhook (#31318)
  chore: add aria-label to Select Inputs at Engagement Dashboard (#31249)
  fix: engagement dashboard timezone selector (#31248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants