fix: engagement dashboard timezone selector - #31248
Merged
kodiakhq[bot] merged 10 commits intoJan 3, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: f8337a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31248 +/- ##
============================================
- Coverage 76.67% 59.41% -17.27%
============================================
Files 277 1793 +1516
Lines 8966 34900 +25934
Branches 1695 7244 +5549
============================================
+ Hits 6875 20735 +13860
- Misses 1667 12567 +10900
- Partials 424 1598 +1174
Flags with carried forward coverage won't be shown. Click here to find out more. |
elfajriharsuda
approved these changes
Dec 31, 2023
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
dougfabris
approved these changes
Jan 3, 2024
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 5, 2024
…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: chore: add gitpod config file for quick setup (#30921) feat: Allow user to set timeout of outgoing webhook (#31222) feat: added modal confirmation before pinning message (#31348) fix: not being able to access or create rooms with join code (#31270) chore: services changes on lifecycle methods + throw if svc is not available (#31375) test: bump playwright (#31376) i18n: update translations (#29462) i18n: adds video call translations for Persian language (#30406) regression: `AppRow` bundleIn verification (#31373) feat: Add Desktop PDF viewer (#31279) fix: Attachments not collapsing when using incoming webhook (#31318) chore: add aria-label to Select Inputs at Engagement Dashboard (#31249) fix: engagement dashboard timezone selector (#31248)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Due to the ResponsiveHeatMap component work with SVG and it edits a lot's the DOM tree in every Timezone changes, the UI gets frozen for a bit.
Upgrading the nivo package and replacing the
ResponsiveHeatMapwithResponsiveHeatMapCanvasfixed the issue.Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/WM-198