feat: added modal confirmation before pinning message by Sayan4444 · Pull Request #31348 · RocketChat/Rocket.Chat

Sayan4444 · 2024-01-01T06:04:53Z

Proposed changes (including videos or screenshots)

AFTER THE FIX
https://github.com/RocketChat/Rocket.Chat/assets/112304873/2e74a44f-e168-48af-817d-c7b945d1f5b0

REASON BEHIND CHANGES
Made the same changes as done by DISCORD to tackle this issue.

Issue(s)
This should close issues :-
closes #30777

Steps to test or reproduce

Go to Teams/Channel
Click on any of the teams/Channels where you are participant.
Try to Send a Text to the Team/Channel
Try to Edit the Text and See that there is no Cancel Button for Edit Text if the user wants to continue without editing the Text.]

changeset-bot · 2024-01-01T06:04:57Z

🦋 Changeset detected

Latest commit: 327b50f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/models	Patch
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-01-01T06:08:01Z

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9c59a87) 59.38% compared to head (327b50f) 49.36%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #31348       +/-   ##
============================================
- Coverage    59.38%   49.36%   -10.03%     
============================================
  Files         1793     3311     +1518     
  Lines        34909    81366    +46457     
  Branches      7246    16661     +9415     
============================================
+ Hits         20731    40163    +19432     
- Misses       12577    36501    +23924     
- Partials      1601     4702     +3101

Flag	Coverage Δ
e2e	`52.53% <6.25%> (-0.04%)`	⬇️
e2e-api	`40.68% <ø> (?)`
unit	`76.67% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

…ranslations

dougfabris

@Sayan4444 This is the desired result shared by our design team, please check if you can achieve it using <GenericModal />, if you have any questions, let me know!

Also, can you check what happened with the en.i18n.json?

Sayan4444 · 2024-01-03T17:21:03Z

@dougfabris Is this good enough or do you want me to add or correct anything else??

Can you tell me what is wrong about en.i18n.json?, it will be of greate help

dougfabris

@Sayan4444 Thank you so much for the contribution, it was very precise and valuable.
About the en.i18n.json file I think it was some issue syncing your code or with lint.
I made some small changes, just to match our standards and code organization.
Thanks again and I hope to see you contributing more 🚀

Sayan4444 · 2024-01-04T22:10:15Z

@dougfabris Yep I will be contributing more as much as I can as I love solving issues which directly impact the end user experience. Do you have an issue which u are also waiting long time to see someone working on it?

dougfabris · 2024-01-04T22:21:29Z

@Sayan4444 That's awesome to hear from you.
Feel free to navigate through our repository and have fun with whatever you want, we found your choices amazing and we'll be reviewing them as soon as possible!

…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: chore: add gitpod config file for quick setup (#30921) feat: Allow user to set timeout of outgoing webhook (#31222) feat: added modal confirmation before pinning message (#31348) fix: not being able to access or create rooms with join code (#31270) chore: services changes on lifecycle methods + throw if svc is not available (#31375) test: bump playwright (#31376) i18n: update translations (#29462) i18n: adds video call translations for Persian language (#30406) regression: `AppRow` bundleIn verification (#31373) feat: Add Desktop PDF viewer (#31279) fix: Attachments not collapsing when using incoming webhook (#31318) chore: add aria-label to Select Inputs at Engagement Dashboard (#31249) fix: engagement dashboard timezone selector (#31248)

feature: Added modal confirmation before pinning message

b18131c

Sayan4444 requested a review from a team as a code owner January 1, 2024 06:04

dionisio-bot Bot added the stat: needs QA label Jan 1, 2024

ggazzo added the Invalid PR Title label Jan 1, 2024

Sayan4444 changed the title ~~feature: Added modal confirmation before pinning message~~ refactor: Added modal confirmation before pinning message Jan 1, 2024

ggazzo removed the Invalid PR Title label Jan 1, 2024

Sayan4444 changed the title ~~refactor: Added modal confirmation before pinning message~~ Fix: Added modal confirmation before pinning message Jan 1, 2024

ggazzo added the Invalid PR Title label Jan 1, 2024

Sayan4444 changed the title ~~Fix: Added modal confirmation before pinning message~~ fix: Added modal confirmation before pinning message Jan 1, 2024

ggazzo removed the Invalid PR Title label Jan 1, 2024

Sayan4444 changed the title ~~fix: Added modal confirmation before pinning message~~ feat: Added modal confirmation before pinning message Jan 1, 2024

Sayan4444 changed the title ~~feat: Added modal confirmation before pinning message~~ feat: added modal confirmation before pinning message Jan 1, 2024

hugocostadev and others added 2 commits January 2, 2024 10:26

Merge branch 'develop' into pin_message_modal

5db7320

fix: review

d8288b8

dougfabris requested changes Jan 2, 2024

View reviewed changes

Comment thread apps/meteor/client/startup/actionButtons/pinMessage.ts Outdated

Comment thread apps/meteor/client/startup/actionButtons/pinMessage.ts

hugocostadev added the community label Jan 2, 2024

Sayan4444 added 2 commits January 3, 2024 02:07

added the message that will get pinned & removed raw texts and used t…

ffedd07

…ranslations

merged develop to my branch

04a4236

dougfabris requested changes Jan 3, 2024

View reviewed changes

dougfabris added this to the 6.6 milestone Jan 3, 2024

Merge branch 'RocketChat:develop' into pin_message_modal

5aafc60

Sayan4444 added 3 commits January 3, 2024 23:43

Desired UI achieved it using <GenericModal />

ee2f91e

deleted repeated translation text

3b53b8f

fixed all linting errors

2115e6d

Sayan4444 requested a review from dougfabris January 4, 2024 17:33

fix: review

de44571

dougfabris force-pushed the pin_message_modal branch from d7121f4 to de44571 Compare January 4, 2024 19:23

chore: changeset

dac7dfc

dougfabris previously approved these changes Jan 4, 2024

View reviewed changes

chore: update changeset

70c61dd

dougfabris dismissed their stale review via 70c61dd January 4, 2024 19:42

dougfabris previously approved these changes Jan 4, 2024

View reviewed changes

fix: fontScale prop and HTML semantic

562aaa7

hugocostadev dismissed dougfabris’s stale review via 562aaa7 January 5, 2024 14:25

Merge branch 'develop' into pin_message_modal

6e55dee

hugocostadev approved these changes Jan 5, 2024

View reviewed changes

dougfabris added the stat: QA skipped label Jan 5, 2024

dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 5, 2024

Merge branch 'develop' into pin_message_modal

327b50f

dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 5, 2024

kodiakhq Bot merged commit 47331ba into RocketChat:develop Jan 5, 2024

Sayan4444 deleted the pin_message_modal branch January 5, 2024 15:51

milton-rucks mentioned this pull request Feb 1, 2024

Hide system message pin/unpin message #16885

Closed

rocketchat-github-ci mentioned this pull request Feb 1, 2024

Release 6.6.0 #31556

Merged

Navigation Menu

Uh oh!

feat: added modal confirmation before pinning message - #31348

feat: added modal confirmation before pinning message#31348
kodiakhq[bot] merged 15 commits into
RocketChat:developfrom
Sayan4444:pin_message_modal

Sayan4444 commented Jan 1, 2024 •

edited by hugocostadev

Loading

Uh oh!

changeset-bot Bot commented Jan 1, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Jan 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dougfabris left a comment •

edited

Loading

Uh oh!

Sayan4444 commented Jan 3, 2024 •

edited

Loading

Uh oh!

dougfabris left a comment •

edited

Loading

Uh oh!

Sayan4444 commented Jan 4, 2024

Uh oh!

dougfabris commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Sayan4444 commented Jan 1, 2024 • edited by hugocostadev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov Bot commented Jan 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

dougfabris left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sayan4444 commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougfabris left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sayan4444 commented Jan 4, 2024

Uh oh!

dougfabris commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sayan4444 commented Jan 1, 2024 •

edited by hugocostadev

Loading

changeset-bot Bot commented Jan 1, 2024 •

edited

Loading

codecov Bot commented Jan 1, 2024 •

edited

Loading

dougfabris left a comment •

edited

Loading

Sayan4444 commented Jan 3, 2024 •

edited

Loading

dougfabris left a comment •

edited

Loading