chore: Meteor 3 / NodeJS 18 upgrade - #29112
Closed
KevLehman wants to merge 100 commits into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # apps/meteor/app/integrations/server/api/api.js
# Conflicts: # apps/meteor/package.json # yarn.lock
# Conflicts: # apps/meteor/.meteor/packages # apps/meteor/client/startup/startup.ts
| this.allowedCordovaOrigins = /^http:\/\/localhost:12[0-9]{3}$/; | ||
| } | ||
|
|
||
| this.originRE = new RegExp(`^https?:\/\/(${rootUrl ? rootUrl : ''}${mobileRootUrl ? ('|' + mobileRootUrl) : ''})$`); |
Check failure
Code scanning / CodeQL
Regular expression injection
| let injectHtml = ''; | ||
| for (id in objs) { | ||
| obj = _.isFunction(objs[id]) ? objs[id](res) : objs[id]; | ||
| injectHtml += ` <script id='${id.replace("'", ''')}' type='application/ejson'>${EJSON.stringify(obj)}</script>\n`; |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| let injectHtml = ''; | ||
| for (id in metas) { | ||
| const meta = this._evalToText(metas[id], res, html); | ||
| (injectHtml += ` <meta id='${id.replace("'", ''')}' content='${meta.replace("'", ''')}'>\n`), res; |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| let injectHtml = ''; | ||
| for (id in metas) { | ||
| const meta = this._evalToText(metas[id], res, html); | ||
| (injectHtml += ` <meta id='${id.replace("'", ''')}' content='${meta.replace("'", ''')}'>\n`), res; |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
added 9 commits
December 22, 2023 09:32
This was referenced Jan 3, 2024
This was referenced Jan 4, 2024
Merged
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Member
Author
|
It finally happened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments