Skip to content

Conversation

@gabriellsh
Copy link
Member

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo changed the title [NEW] Info page [NEW] Server Info page Nov 17, 2020
…info_page

* 'develop' of github.com:RocketChat/Rocket.Chat: (255 commits)
  Chore: Add tests for the api/licenses.* endpoints (#20041)
  Language update from LingoHub 🤖 on 2021-01-04Z (#20034)
  [FIX] Omnichannel Agents unable to take new chats in the queue (#20022)
  [FIX] Omnichannel Business Hours form is not being rendered (#20007)
  Language update from LingoHub 🤖 (#20013)
  Chore: Fix i18n duplicated keys (#19998)
  [FIX] Agent information panel not rendering (#19965)
  [FIX] Apps Create Room method with agent not working (#19997)
  Chore: add tests to api/instances.get endpoint  (#19988)
  Bump version to 3.11.0-develop
  Bump version to 3.10.0
  Bump version to 3.10.0-rc.4
  Bump version to 3.10.0-rc.3
  Bump version to 3.10.0-rc.2
  Bump version to 3.10.0-rc.1
  Bump version to 3.10.0-rc.0
  Revert "[NEW] Storj integration (#19932)"
  Regression: polishing licenses endpoints  (#19981)
  Regression: Double Scrollbars on tables (#19980)
  Regression: Add currently running instance to instances.get endpoint (#19955)
  ...
…info_page

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962)
  [FIX] minWidth in FileIcon to prevent layout to broke (#19942)
  [IMPROVE] Add extra SAML settings to update room subs and add private room subs (#19489)
  [IMPROVE] Rewrite User Dropdown and Kebab menu. (#20070)
  Language update from LingoHub 🤖 on 2021-01-11Z (#20146)
  [FIX] User registration updating wrong subscriptions (#20128)
  Rewrite Discussion Metric (#20117)
  [IMPROVE] Don't use global search by default (#19777)
  [FIX] Tabbar is opened (#20122)
  [FIX] Actions from User Info panel (#20073)
  Update password policy English translation (#20118)
  [FIX] Messages being updated when not required after user changes his profile (#20114)
  Custom fields not storing additional form values, fixing label and solving duplicated register. (#19953)
  Fix livechat room breaking after return (#20089)
  [FIX] Meteor errors not translating for toast messages (#19993)
  [FIX] Profile picture changing with username (#19992)
  [FIX] Search list filter (#19937)
  chore: Change return button (#20045)
  Rewrite : Message Thread metrics (#20051)
  [FIX] Omnichannel raw model importing meteor dependency (#20093)
  ...
@ggazzo ggazzo marked this pull request as ready for review January 12, 2021 15:37
@ggazzo ggazzo added this to the 3.11.0 milestone Jan 12, 2021
@ggazzo ggazzo merged commit 1494631 into develop Jan 12, 2021
@ggazzo ggazzo deleted the new/info_page branch January 12, 2021 16:45
gabriellsh added a commit that referenced this pull request Jan 14, 2021
…rewrite-announcement

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Regression: Info Page Icon style and usage graph breaking (#20180)
  Chore: Change console.warning() to console.warn() (#20200)
  [FIX] Room's list showing all rooms with same name (#20176)
  Regression: Change sort icon (#20177)
  [FIX] Wrong userId when open own user profile (#20181)
  [FIX] Livechat.RegisterGuest method removing unset fields (#20124)
  [IMPROVE] Rewrite Prune Messages as React component (#19900)
  [FIX] Change header's favorite icon to filled star (#20174)
  [FIX] Initial values update on Account Preferences  (#19938)
  [FIX] Unable to reset password by Email if upper case character is present (#19643)
  [FIX] Video call message not translated (#18722)
  [NEW] Server Info page (#19517)
  [IMPROVE] Title for user avatar buttons (#20083)
  [FIX] Admin User Info email verified status (#20110)
  [IMPROVE] Tooltip added for Kebab menu on chat header (#20116)
  [FIX] Translate keyword for 'Showing results of' in tables (#20134)
  [FIX] Markdown added for Header Room topic (#20021)
  [FIX] Status circle in profile section (#20016)
  [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962)
  [FIX] minWidth in FileIcon to prevent layout to broke (#19942)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
Comment on lines +54 to +55
{t('HEAD')}: ({s(() => commit.hash.slice(0, 9))}) <br />
{t('Branch')}: {s(() => commit.branch)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ggazzo , apparently if the app is deployed with a tar.gz (As it's done on multiple PaaS) : git metadata aren't available (commit.hash and commit.branch). I describe the problem here : #21794

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ggazzo. It's @gabriellsh that I wanted to ping.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to ping you @gabriellsh, but is this problem #21794 fixed in newer versions (e.g. 3.15.1)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upgraded to version 3.16.1. (deployed with a tar.gz) the admin view info is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants