[FIX] Agent information panel not rendering #19965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld when it has value.
renatobecker
requested changes
Dec 25, 2020
Contributor
renatobecker
left a comment
renatobecker
left a comment
There was a problem hiding this comment.
@rafaelblink we need to fix the UI components on the Panel as well.
Neither the buttons displayed below the user avatar nor the avatar is okay, both need fixes, look:
User Info Panel:
Agent Info Panel:
renatobecker
changed the title
renatobecker
approved these changes
Dec 29, 2020
gabriellsh
added a commit
that referenced
this pull request
Jan 4, 2021
…info_page * 'develop' of github.com:RocketChat/Rocket.Chat: (255 commits) Chore: Add tests for the api/licenses.* endpoints (#20041) Language update from LingoHub 🤖 on 2021-01-04Z (#20034) [FIX] Omnichannel Agents unable to take new chats in the queue (#20022) [FIX] Omnichannel Business Hours form is not being rendered (#20007) Language update from LingoHub 🤖 (#20013) Chore: Fix i18n duplicated keys (#19998) [FIX] Agent information panel not rendering (#19965) [FIX] Apps Create Room method with agent not working (#19997) Chore: add tests to api/instances.get endpoint (#19988) Bump version to 3.11.0-develop Bump version to 3.10.0 Bump version to 3.10.0-rc.4 Bump version to 3.10.0-rc.3 Bump version to 3.10.0-rc.2 Bump version to 3.10.0-rc.1 Bump version to 3.10.0-rc.0 Revert "[NEW] Storj integration (#19932)" Regression: polishing licenses endpoints (#19981) Regression: Double Scrollbars on tables (#19980) Regression: Add currently running instance to instances.get endpoint (#19955) ...
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Changing default import to named import and only showing MaxNumber field when it has value. * Agents (edit and info) enhancements with translation missing and alignments. Co-authored-by: Renato Becker <[email protected]>
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Changing default import to named import and only showing MaxNumber field when it has value. * Agents (edit and info) enhancements with translation missing and alignments. Co-authored-by: Renato Becker <[email protected]>
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Jan 11, 2021
* rocketchat/master: Bump version to 3.10.3 [FIX] User registration updating wrong subscriptions (RocketChat#20128) Bump version to 3.10.2 [FIX] Tabbar is opened (RocketChat#20122) Bump version to 3.10.1 [FIX] Actions from User Info panel (RocketChat#20073) [FIX] Messages being updated when not required after user changes his profile (RocketChat#20114) Custom fields not storing additional form values, fixing label and solving duplicated register. (RocketChat#19953) Fix livechat room breaking after return (RocketChat#20089) [FIX] Omnichannel raw model importing meteor dependency (RocketChat#20093) [FIX] User Audio notification preference not being applied (RocketChat#20061) [FIX] OAuth users being asked to change password on second login (RocketChat#20003) [FIX] Omnichannel Agents unable to take new chats in the queue (RocketChat#20022) [FIX] Omnichannel Business Hours form is not being rendered (RocketChat#20007) [FIX] Agent information panel not rendering (RocketChat#19965) [FIX] Apps Create Room method with agent not working (RocketChat#19997)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on any row on Agents list an error is raised and the panel is not rendered.
Proposed changes (including videos or screenshots)
I changed only two things into
MaxChatsPerAgentDisplaycomponent:default importfor anamed import.With value
With no value
Issue(s)
Steps to test or reproduce
With your Rocket.Chat as Enterprise:
Omnichannel panel > Agents > Click on a row of a specific agent > nothing will be rendered on page.
Further comments