Skip to content

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Dec 29, 2020

Proposed changes (including videos or screenshots)

Issue(s)

While using modify.getCreator().getLivechatCreator().createRoom(visitor, targetAgent) I was getting following error

Match error: Missing key 'username'

Steps to test or reproduce

Further comments

@renatobecker renatobecker added this to the 3.11.0 milestone Dec 30, 2020
@renatobecker renatobecker changed the title [FIX] Apps Create-Room method with agent not working [FIX] Creation of Omnichannel rooms not working correctly through the Apps when the agent parameter is set Dec 30, 2020
@renatobecker renatobecker merged commit 01f9c30 into develop Dec 30, 2020
@renatobecker renatobecker deleted the fix/apps-createRoom-with-agent branch December 30, 2020 11:42
gabriellsh added a commit that referenced this pull request Jan 4, 2021
…info_page

* 'develop' of github.com:RocketChat/Rocket.Chat: (255 commits)
  Chore: Add tests for the api/licenses.* endpoints (#20041)
  Language update from LingoHub 🤖 on 2021-01-04Z (#20034)
  [FIX] Omnichannel Agents unable to take new chats in the queue (#20022)
  [FIX] Omnichannel Business Hours form is not being rendered (#20007)
  Language update from LingoHub 🤖 (#20013)
  Chore: Fix i18n duplicated keys (#19998)
  [FIX] Agent information panel not rendering (#19965)
  [FIX] Apps Create Room method with agent not working (#19997)
  Chore: add tests to api/instances.get endpoint  (#19988)
  Bump version to 3.11.0-develop
  Bump version to 3.10.0
  Bump version to 3.10.0-rc.4
  Bump version to 3.10.0-rc.3
  Bump version to 3.10.0-rc.2
  Bump version to 3.10.0-rc.1
  Bump version to 3.10.0-rc.0
  Revert "[NEW] Storj integration (#19932)"
  Regression: polishing licenses endpoints  (#19981)
  Regression: Double Scrollbars on tables (#19980)
  Regression: Add currently running instance to instances.get endpoint (#19955)
  ...
@renatobecker renatobecker modified the milestones: 3.11.0, 3.10.1 Jan 6, 2021
@sampaiodiego sampaiodiego mentioned this pull request Jan 8, 2021
vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request Jan 11, 2021
* rocketchat/master:
  Bump version to 3.10.3
  [FIX] User registration updating wrong subscriptions (RocketChat#20128)
  Bump version to 3.10.2
  [FIX] Tabbar is opened (RocketChat#20122)
  Bump version to 3.10.1
  [FIX] Actions from User Info panel (RocketChat#20073)
  [FIX] Messages being updated when not required after user changes his profile (RocketChat#20114)
  Custom fields not storing additional form values, fixing label and solving duplicated register. (RocketChat#19953)
  Fix livechat room breaking after return (RocketChat#20089)
  [FIX] Omnichannel raw model importing meteor dependency (RocketChat#20093)
  [FIX] User Audio notification preference not being applied (RocketChat#20061)
  [FIX] OAuth users being asked to change password on second login (RocketChat#20003)
  [FIX] Omnichannel Agents unable to take new chats in the queue (RocketChat#20022)
  [FIX] Omnichannel Business Hours form is not being rendered (RocketChat#20007)
  [FIX] Agent information panel not rendering (RocketChat#19965)
  [FIX] Apps Create Room method with agent not working (RocketChat#19997)
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants