Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Dec 31, 2020

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

With the new 3.10.0 version update the Links in topic section below room name were not working, for more info refer issue #20018

Issue(s)

closes #20018

Steps to test or reproduce

Steps explained on issue.

Further comments

topic-links

@yash-rajpal
Copy link
Member Author

@gabriellsh Please review!

@ggazzo ggazzo added this to the 3.11.0 milestone Jan 12, 2021
@ggazzo ggazzo changed the title [FIX] Markdown added for topic links below room name [FIX] Markdown added for Header Room topic Jan 12, 2021
@ggazzo ggazzo merged commit a3efc41 into RocketChat:develop Jan 12, 2021
gabriellsh added a commit that referenced this pull request Jan 14, 2021
…rewrite-announcement

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Regression: Info Page Icon style and usage graph breaking (#20180)
  Chore: Change console.warning() to console.warn() (#20200)
  [FIX] Room's list showing all rooms with same name (#20176)
  Regression: Change sort icon (#20177)
  [FIX] Wrong userId when open own user profile (#20181)
  [FIX] Livechat.RegisterGuest method removing unset fields (#20124)
  [IMPROVE] Rewrite Prune Messages as React component (#19900)
  [FIX] Change header's favorite icon to filled star (#20174)
  [FIX] Initial values update on Account Preferences  (#19938)
  [FIX] Unable to reset password by Email if upper case character is present (#19643)
  [FIX] Video call message not translated (#18722)
  [NEW] Server Info page (#19517)
  [IMPROVE] Title for user avatar buttons (#20083)
  [FIX] Admin User Info email verified status (#20110)
  [IMPROVE] Tooltip added for Kebab menu on chat header (#20116)
  [FIX] Translate keyword for 'Showing results of' in tables (#20134)
  [FIX] Markdown added for Header Room topic (#20021)
  [FIX] Status circle in profile section (#20016)
  [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962)
  [FIX] minWidth in FileIcon to prevent layout to broke (#19942)
  ...
@xmedeko
Copy link

xmedeko commented Jan 14, 2021

Since this is regression and a simple fix, it's pity it's scheduled for 3.11 and not the next bugfix release 3.10.4 (or 3.10.5).
E.g. check your public server https://open.rocket.chat/channel/support - room title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links in Topics stopped working - upgraded to 3.10.0

3 participants