[IMPROVE] Don't use global search by default #19777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Almost 100% of the time I uncheck the global search. 👍 |
|
By default no options should be selected by default. This issue is an important one specially for large number of histories. |
sampaiodiego
approved these changes
Jan 8, 2021
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jan 12, 2021
…info_page * 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits) [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962) [FIX] minWidth in FileIcon to prevent layout to broke (#19942) [IMPROVE] Add extra SAML settings to update room subs and add private room subs (#19489) [IMPROVE] Rewrite User Dropdown and Kebab menu. (#20070) Language update from LingoHub 🤖 on 2021-01-11Z (#20146) [FIX] User registration updating wrong subscriptions (#20128) Rewrite Discussion Metric (#20117) [IMPROVE] Don't use global search by default (#19777) [FIX] Tabbar is opened (#20122) [FIX] Actions from User Info panel (#20073) Update password policy English translation (#20118) [FIX] Messages being updated when not required after user changes his profile (#20114) Custom fields not storing additional form values, fixing label and solving duplicated register. (#19953) Fix livechat room breaking after return (#20089) [FIX] Meteor errors not translating for toast messages (#19993) [FIX] Profile picture changing with username (#19992) [FIX] Search list filter (#19937) chore: Change return button (#20045) Rewrite : Message Thread metrics (#20051) [FIX] Omnichannel raw model importing meteor dependency (#20093) ...
Merged
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Sets the Global Search option to not be set by default.
Issue(s)
Currently Global Chat search is set to be used by default, this causes a lot of stress on servers with bigger chat histories and usually only bring not needed results as users usually search for commonly used words in their local chats. When an actual more refined search is used, global can be applied by checking the checkbox.
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Global chat search is not set by default now.
Further comments