[FIX] Livechat.RegisterGuest method removing unset fields #20124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
changed the title
…ethod' into omnichannel/fix-register-guest-method
renatobecker
commented
Jan 11, 2021
renatobecker
commented
Jan 11, 2021
renatobecker
requested review from
rafaelblink
and removed request for
rafaelblink
renatobecker
commented
Jan 12, 2021
renatobecker
commented
Jan 12, 2021
| <Field.Label>{t('Email')}</Field.Label> | ||
| <Field.Row> | ||
| <TextInput error={emailError} flexGrow={1} value={email} onChange={handleEmail} addon={<Icon name='mail' size='x20'/>}/> | ||
| <TextInput onBlur={checkEmailExists} error={emailError} flexGrow={1} value={email} onChange={handleEmail} addon={<Icon name='mail' size='x20'/>}/> |
Contributor
Author
There was a problem hiding this comment.
When I set an email and remove it, I get this:
…ethod' into omnichannel/fix-register-guest-method
…or phone if empty phone.
rafaelblink
approved these changes
Jan 12, 2021
gabriellsh
added a commit
that referenced
this pull request
Jan 13, 2021
…info_page * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Room's list showing all rooms with same name (#20176) Regression: Change sort icon (#20177) [FIX] Wrong userId when open own user profile (#20181) [FIX] Livechat.RegisterGuest method removing unset fields (#20124)
gabriellsh
added a commit
that referenced
this pull request
Jan 14, 2021
…rewrite-announcement * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) Regression: Info Page Icon style and usage graph breaking (#20180) Chore: Change console.warning() to console.warn() (#20200) [FIX] Room's list showing all rooms with same name (#20176) Regression: Change sort icon (#20177) [FIX] Wrong userId when open own user profile (#20181) [FIX] Livechat.RegisterGuest method removing unset fields (#20124) [IMPROVE] Rewrite Prune Messages as React component (#19900) [FIX] Change header's favorite icon to filled star (#20174) [FIX] Initial values update on Account Preferences (#19938) [FIX] Unable to reset password by Email if upper case character is present (#19643) [FIX] Video call message not translated (#18722) [NEW] Server Info page (#19517) [IMPROVE] Title for user avatar buttons (#20083) [FIX] Admin User Info email verified status (#20110) [IMPROVE] Tooltip added for Kebab menu on chat header (#20116) [FIX] Translate keyword for 'Showing results of' in tables (#20134) [FIX] Markdown added for Header Room topic (#20021) [FIX] Status circle in profile section (#20016) [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962) [FIX] minWidth in FileIcon to prevent layout to broke (#19942) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
After changes made on #19931, the
Livechat.RegisterGuestmethod started removing properties from the visitor inappropriately. The properties that did not receive value were removed from the object.Those changes were made to support the new Contact Form, but now the form has its own method to deal with Contact data so those changes are no longer necessary.
Issue(s)
Steps to test or reproduce
Further comments