[FIX] Actions from User Info panel #20073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please review:) |
gabriellsh
requested changes
Jan 6, 2021
| close={closeModal} | ||
| confirmText={t('Yes_remove_user')} | ||
| confirm={() => { removeUserAction({ roomId: rid, userId: uid }); closeModal(); }} | ||
| confirm={() => { removeUserAction({ roomId: rid, username: user.username }); closeModal(); }} |
Member
There was a problem hiding this comment.
Although this works for the user removal, it's not the ideal fix, since uid is used in other places that should be broken too. Try to see where this user object is coming from and why the _id property is not coming along with it.
This issue looks pretty bad, so I'll give you another couple of hours to figure it out, otherwise I'll fix it.
Contributor
Author
|
@gabriellsh Please review! |
Member
Nice man! Did you test it again to see if the new fix is working? |
Contributor
Author
removeuser-pr.mp4@gabriellsh Have a look! |
gabriellsh
approved these changes
Jan 7, 2021
|
@Darshilp326 I think your changes would also solve this #20095 , So should I close it ? |
sampaiodiego
changed the title
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 8, 2021
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 8, 2021
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Jan 11, 2021
* rocketchat/master: Bump version to 3.10.3 [FIX] User registration updating wrong subscriptions (RocketChat#20128) Bump version to 3.10.2 [FIX] Tabbar is opened (RocketChat#20122) Bump version to 3.10.1 [FIX] Actions from User Info panel (RocketChat#20073) [FIX] Messages being updated when not required after user changes his profile (RocketChat#20114) Custom fields not storing additional form values, fixing label and solving duplicated register. (RocketChat#19953) Fix livechat room breaking after return (RocketChat#20089) [FIX] Omnichannel raw model importing meteor dependency (RocketChat#20093) [FIX] User Audio notification preference not being applied (RocketChat#20061) [FIX] OAuth users being asked to change password on second login (RocketChat#20003) [FIX] Omnichannel Agents unable to take new chats in the queue (RocketChat#20022) [FIX] Omnichannel Business Hours form is not being rendered (RocketChat#20007) [FIX] Agent information panel not rendering (RocketChat#19965) [FIX] Apps Create Room method with agent not working (RocketChat#19997)
gabriellsh
added a commit
that referenced
this pull request
Jan 12, 2021
…info_page * 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits) [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962) [FIX] minWidth in FileIcon to prevent layout to broke (#19942) [IMPROVE] Add extra SAML settings to update room subs and add private room subs (#19489) [IMPROVE] Rewrite User Dropdown and Kebab menu. (#20070) Language update from LingoHub 🤖 on 2021-01-11Z (#20146) [FIX] User registration updating wrong subscriptions (#20128) Rewrite Discussion Metric (#20117) [IMPROVE] Don't use global search by default (#19777) [FIX] Tabbar is opened (#20122) [FIX] Actions from User Info panel (#20073) Update password policy English translation (#20118) [FIX] Messages being updated when not required after user changes his profile (#20114) Custom fields not storing additional form values, fixing label and solving duplicated register. (#19953) Fix livechat room breaking after return (#20089) [FIX] Meteor errors not translating for toast messages (#19993) [FIX] Profile picture changing with username (#19992) [FIX] Search list filter (#19937) chore: Change return button (#20045) Rewrite : Message Thread metrics (#20051) [FIX] Omnichannel raw model importing meteor dependency (#20093) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Users can be removed from channels without any error message.
remove-user-pr.mp4
Issue(s)
Closes #20058
Closes #20095
Steps to test or reproduce
Further comments