[atgutier]

A HW queue is bound to a single XCD by SoC::assign_queue_cp(), so every workgroup of every dispatch on that queue is placed by that one XCD's command processor on that one XCD's compute units. On the 8-XCD CDNA4 configs a single-queue application reaches 32 of the 256 CUs the topology advertises, but nothing in the tree measured this.

Count workgroups placed per command processor and expose the per-XCD histogram from the SoC, then pin current behavior in xcd_distribution_test: one queue confines the whole grid to one XCD, and only opening multiple queues reaches multiple XCDs. The follow-on fan-out work flips the first expectation.

[therock-pr-bot]

❌ PR Check — Action Required

Check	Status	Details
📝 PR Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples: • JIRA ID : TESTAUTO-6039 • JIRA ID - #330 • JIRA ID #330 • JIRA ID (on separate line) ROCM-25757 • ISSUE ID : TESTUTO-3334 • ISSUE ID #3334 • ISSUE ID - TESTAUTO-3433 • ISSUE ID (on separate line) AIRUNTIME-2352 • ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234 • Closes #10 • Fixes octo-org/octo-repo#100 • Resolves: #123 • #123 • https://github.com/<org_name>/<repo_name>/issues/123 Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

• ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[Copilot]

Pull request overview

Adds observability for how workgroups are distributed across XCDs in rocjitsu’s multi-XCD SoC emulation, and introduces a regression test that pins current single-queue behavior (all workgroups land on one XCD) versus multi-queue behavior (queues rotate across XCDs).

Changes:

• Track a per-command-processor cumulative count of dispatched workgroups and expose it via a new SoC::dispatched_workgroups_per_xcd() histogram helper.
• Add xcd_distribution_test.cpp to validate current XCD placement behavior for one queue vs. multiple queues.
• Wire the new test into the rocjitsu_tests CMake target.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
emulation/rocjitsu/tests/xcd_distribution_test.cpp	New tests validating XCD workgroup distribution behavior.
emulation/rocjitsu/tests/CMakeLists.txt	Adds the new test source to the test executable.
emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/vm/soc.h	Adds SoC-level per-XCD workgroup histogram accessor.
emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/vm/amdgpu/command_processor.h	Adds CP accessor and storage for cumulative workgroup dispatch count.
emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/vm/amdgpu/command_processor.cpp	Increments the new cumulative workgroup counter on each workgroup placement.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kuhar]

It would be good to apply the documented RocJITsu style rules consistently in xcd_distribution_test.cpp: rename CONFIG_PATH to kConfigPath (line 37), make XcdDistributionFixture a class with an explicit public: section (line 46), and spell out std::vector<uint64_t> for both counts declarations (lines 96 and 126). These are direct requirements in emulation/rocjitsu/docs/style.md.

[kuhar]

LGTM