Skip to content

Comments

electron-source.electron_36: remove, electron_36-bin: mark as insecure #458485

Merged
yuyuyureka merged 4 commits intoNixOS:masterfrom
yuyuyureka:electron-36-eol
Nov 6, 2025
Merged

electron-source.electron_36: remove, electron_36-bin: mark as insecure #458485
yuyuyureka merged 4 commits intoNixOS:masterfrom
yuyuyureka:electron-36-eol

Conversation

@yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Nov 4, 2025

Packages still using electron_36 (and will be transitively insecure when this PR is merged):

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 4, 2025
@SuperSandro2000
Copy link
Member

bitwarden-desktop will update to electron 37 in the next release bitwarden/clients#16905 which should be any day.

@amarshall
Copy link
Member

amarshall commented Nov 4, 2025

PR to backport electron_37 update to bitwarden-desktop: #458491

@iedame
Copy link
Contributor

iedame commented Nov 4, 2025

heroic's upstream just updated to 36.9.4, I will do some testing to see if we can update earlier or it burst into flames as that package needs some love. I adopted it recently so I will do the best I can.

@teutat3s
Copy link
Member

teutat3s commented Nov 5, 2025

For reference, previously: #442413

@yuyuyureka
Copy link
Contributor Author

@pluiedev since gfn-electron was already behind in the last round and is now the last package depending on electron_35, and has also been officially abandoned upstream, I have removed it for now. Feel free to revert if you want to re-add your own updated fork.

@nix-owners nix-owners bot requested a review from pluiedev November 5, 2025 17:51
@pluiedev
Copy link
Member

pluiedev commented Nov 5, 2025

No worries! It's sad that upstream is in this abandoned state, but I might consider packaging https://github.com/AstralVixen/GeForce-Infinity in its stead if I ever felt like it

@yuyuyureka yuyuyureka added this pull request to the merge queue Nov 6, 2025
Merged via the queue into NixOS:master with commit 5643836 Nov 6, 2025
29 of 31 checks passed
@yuyuyureka yuyuyureka deleted the electron-36-eol branch November 6, 2025 21:39
@NotAShelf
Copy link
Member

NotAShelf commented Nov 7, 2025

I wish you had waited until the weekend so that I had a chance to address this.

@iedame
Copy link
Contributor

iedame commented Nov 7, 2025

I also didn't expect it was going to be merged so fast, I was able to do some testing so I just went ahead and started a PR to bump electron for heroic. Please take a look, hopefully those two will reach unstable together.

@yuyuyureka
Copy link
Contributor Author

yuyuyureka commented Nov 7, 2025

Sorry, I'm in a bit of a hurry because I don't want to have 4 versions with different toolchain patches each, which gets worsened by Rust 1.90 (#459376).

The release cycles are planned out and it's predictable when a version becomes EOL, so this is the same every time. You can set yourself a calendar entry for <X> time before electron_37 goes EOL (2026-Jan-13), to get your packages ready for the next removal. I heard some of the chromium package maintainers have such a (physical) release calendar at home ;)

We can define a minimum announcement time of 7 days for the future though, if that helps.

@iedame
Copy link
Contributor

iedame commented Nov 7, 2025

Thank you, that will definitely help for next time. I will do that! No worries, I understand the hurry.

@fugidev
Copy link
Member

fugidev commented Nov 9, 2025

joplin-desktop: #460058

@teutat3s teutat3s mentioned this pull request Nov 10, 2025
13 tasks
@flokli flokli mentioned this pull request Nov 10, 2025
13 tasks
flokli added a commit to flokli/nixpkgs that referenced this pull request Nov 10, 2025
electron_36 is also EOL and got marked as insecure in NixOS#458485.
@flokli
Copy link
Member

flokli commented Nov 10, 2025

netron: #460405

@teutat3s teutat3s added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 15, 2025
@teutat3s
Copy link
Member

feishin: #461218

flokli added a commit to flokli/nixpkgs that referenced this pull request Nov 24, 2025
electron_36 is also EOL and got marked as insecure in NixOS#458485.

(cherry picked from commit 679ddd6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants