feishin: Bump electron from 36 to 38#461218
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Nov 16, 2025
Merged
Conversation
Feishin will be using electron 38 in version 0.21.3, which is currently in beta. While we're still on 0.21.2, bumping electron doesn't break the app and it still works as expected. Also resolves a warning about Electron versions below 37.0.0 being EOL.
Contributor
Author
|
I'm not sure how this kind of version bumps are handled in nixpkgs, because electron 38 isn't yet used in upstream stable builds. Simply bumping from 36 to 38 doesn't break the build and Feishin seems to be working correctly on my machine. Please let me known if this should be done after Feishin stable is on 0.21.3 or if this can be merged before that. |
This was referenced Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feishin will be using electron 38 in version 0.21.3, which is currently in beta:
jeffvli/feishin@5892088
While we're still on 0.21.2, bumping electron doesn't break the app and it still works as expected.
Also resolves a warning about Electron versions below 37.0.0 being EOL.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.