Skip to content

feishin: Bump electron from 36 to 38#461218

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Daste745:feishin-electron-38
Nov 16, 2025
Merged

feishin: Bump electron from 36 to 38#461218
Aleksanaa merged 1 commit intoNixOS:masterfrom
Daste745:feishin-electron-38

Conversation

@Daste745
Copy link
Contributor

Feishin will be using electron 38 in version 0.21.3, which is currently in beta:
jeffvli/feishin@5892088

While we're still on 0.21.2, bumping electron doesn't break the app and it still works as expected.

Also resolves a warning about Electron versions below 37.0.0 being EOL.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Feishin will be using electron 38 in version 0.21.3, which is
currently in beta.

While we're still on 0.21.2, bumping electron doesn't break the app and
it still works as expected.

Also resolves a warning about Electron versions below 37.0.0 being EOL.
@Daste745
Copy link
Contributor Author

I'm not sure how this kind of version bumps are handled in nixpkgs, because electron 38 isn't yet used in upstream stable builds.

Simply bumping from 36 to 38 doesn't break the build and Feishin seems to be working correctly on my machine.

Please let me known if this should be done after Feishin stable is on 0.21.3 or if this can be merged before that.

@nixpkgs-ci nixpkgs-ci bot requested review from jlbribeiro and onny November 13, 2025 12:05
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 13, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 16, 2025
Merged via the queue into NixOS:master with commit e81dc99 Nov 16, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants