heroic-unwrapped: bump electron version#459372
Merged
yuyuyureka merged 1 commit intoNixOS:masterfrom Nov 7, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
nixpkgs-ci
bot
removed
the
9.needs: reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned Electron version is EOL. Prompted by #458485, which was already merged after 2 days of notice.
Upstream is still using 36, but from my testing bumping to 37 doesn't break anything.
I would have preferred to dedicate a little more time to bump this with more testing since I just adopted this package, but considering it will be marked as insecure soon, I decided to bump it and fix any issues later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.