Skip to content

Comments

electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL#442413

Merged
yayayayaka merged 2 commits intoNixOS:masterfrom
teutat3s:electron_35-eol
Sep 22, 2025
Merged

electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL#442413
yayayayaka merged 2 commits intoNixOS:masterfrom
teutat3s:electron_35-eol

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Sep 12, 2025

Previously:

electron_35 is EOL since 2025-09-02.
https://www.electronjs.org/docs/latest/tutorial/electron-timelines (permalink)

This PR removes the source build on Linux for electron 35 and marks the binary variants for Darwin and Linux as insecure.
electron_35-bin will still be available until most dependent packages have updated their versions. Linux will simply use the binary package instead of the source build, just like Darwin.

After this PR has been merged, users will be able opt-into the EOL version of electron as outlined by this eval error message:

       error: Package ‘electron-35.7.5’ in /home/teutat3s/CodeRoom/github.com/NixOS/nixpkgs/pkgs/development/tools/electron/binary/generic.nix:43 is marked as insecure, refusing to evaluate.


       Known issues:
        - Electron version 35.7.5 is EOL

       You can install it anyway by allowing this package, using the
       following methods:

       a) To temporarily allow all insecure packages, you can use an environment
          variable for a single invocation of the nix tools:

            $ export NIXPKGS_ALLOW_INSECURE=1

          Note: When using `nix shell`, `nix build`, `nix develop`, etc with a flake,
                then pass `--impure` in order to allow use of environment variables.

       b) for `nixos-rebuild` you can add ‘electron-35.7.5’ to
          `nixpkgs.config.permittedInsecurePackages` in the configuration.nix,
          like so:

            {
              nixpkgs.config.permittedInsecurePackages = [
                "electron-35.7.5"
              ];
            }

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
          ‘electron-35.7.5’ to `permittedInsecurePackages` in
          ~/.config/nixpkgs/config.nix, like so:

            {
              permittedInsecurePackages = [
                "electron-35.7.5"
              ];
            }

The following packages are affected by this. Note that those package will continue to work, but users will be presented with the eval error above and have to opt-in.

If you are pinged as one of the maintainers of such package, you can do one of the following:

  1. Check if upstream supports a newer electron version and open a PR in nixpkgs to use that instead OR
  2. Try using a newer electron version than upstream suggests and if that turns out to be stable, open a PR in nixpkgs to use that instead OR
  3. Do nothing in nixpkgs, and maybe make upstream aware that their electron version is EOL.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s changed the title Electron 35 eol electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL Sep 12, 2025
@teutat3s teutat3s added backport release-25.05 1.severity: security Issues which raise a security issue, or PRs that fix one labels Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 12, 2025
@pluiedev
Copy link
Member

Notified upstream via hmlendea/gfn-electron#276. I'll look into updating gfn-electron to newer Electron versions before the removal date

@yuyuyureka
Copy link
Contributor

For ente-desktop: #442605

@fugidev
Copy link
Member

fugidev commented Sep 13, 2025

joplin-desktop: #442657

@teutat3s
Copy link
Member Author

We plan to merge this PR on 2025-09-19 to give maintainers a bit more time.

@pyrox0
Copy link
Member

pyrox0 commented Sep 17, 2025

Marking as draft for a clear signal to not merge yet. Feel free to mark as ready to review on day of merge.

@pyrox0 pyrox0 marked this pull request as draft September 17, 2025 15:50
@TomaSajt
Copy link
Contributor

@teutat3s
Copy link
Member Author

teutat3s commented Sep 18, 2025

For mattermost-desktop: #444002
For penpot-desktop: #407337 (plus upstream has since released several newer versions)

@teutat3s teutat3s marked this pull request as ready for review September 19, 2025 08:25
@yayayayaka yayayayaka added this pull request to the merge queue Sep 22, 2025
Merged via the queue into NixOS:master with commit 29dfcc6 Sep 22, 2025
50 of 51 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Sep 22, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-442413-to-release-25.05 origin/release-25.05
cd .worktree/backport-442413-to-release-25.05
git switch --create backport-442413-to-release-25.05
git cherry-pick -x f4f73f206e8a198a69f1ba5b3a8be05a1adafed2 b67464cfb67bc88be9a8b627b1f0ab22618746fa

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Sep 22, 2025
@teutat3s teutat3s deleted the electron_35-eol branch September 23, 2025 08:57
@Cryolitia
Copy link
Member

gridtracker2: #446675

Cryolitia added a commit to Cryolitia-Forks/nixpkgs that referenced this pull request Sep 27, 2025
The runtimeInputs seems not needed. It's electron's dependency but not directly gridtracker2's.

Due to [1], update electron to newest. LGTM.

1. NixOS#442413

Signed-off-by: Cryolitia PukNgae <Cryolitia@gmail.com>
@mdaniels5757 mdaniels5757 added 8.has: port to stable This PR already has a backport to the stable release. and removed backport release-25.05 labels Oct 5, 2025
@yuyuyureka yuyuyureka mentioned this pull request Jan 26, 2026
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants