electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL#442413
Merged
yayayayaka merged 2 commits intoNixOS:masterfrom Sep 22, 2025
Merged
Conversation
Cryolitia
approved these changes
Sep 12, 2025
qxrein
approved these changes
Sep 12, 2025
Member
|
Notified upstream via hmlendea/gfn-electron#276. I'll look into updating gfn-electron to newer Electron versions before the removal date |
Contributor
|
For ente-desktop: #442605 |
Member
|
joplin-desktop: #442657 |
Member
Author
|
We plan to merge this PR on 2025-09-19 to give maintainers a bit more time. |
Member
|
Marking as draft for a clear signal to not merge yet. Feel free to mark as ready to review on day of merge. |
This was referenced Sep 17, 2025
Contributor
Member
Author
|
For |
yayayayaka
approved these changes
Sep 22, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-442413-to-release-25.05 origin/release-25.05
cd .worktree/backport-442413-to-release-25.05
git switch --create backport-442413-to-release-25.05
git cherry-pick -x f4f73f206e8a198a69f1ba5b3a8be05a1adafed2 b67464cfb67bc88be9a8b627b1f0ab22618746fa |
This was referenced Sep 23, 2025
Member
|
|
Cryolitia
added a commit
to Cryolitia-Forks/nixpkgs
that referenced
this pull request
Sep 27, 2025
The runtimeInputs seems not needed. It's electron's dependency but not directly gridtracker2's. Due to [1], update electron to newest. LGTM. 1. NixOS#442413 Signed-off-by: Cryolitia PukNgae <Cryolitia@gmail.com>
13 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
electron_35is EOL since 2025-09-02.https://www.electronjs.org/docs/latest/tutorial/electron-timelines (permalink)
This PR removes the source build on Linux for electron 35 and marks the binary variants for Darwin and Linux as insecure.
electron_35-binwill still be available until most dependent packages have updated their versions. Linux will simply use the binary package instead of the source build, just like Darwin.After this PR has been merged, users will be able opt-into the EOL version of electron as outlined by this eval error message:
The following packages are affected by this. Note that those package will continue to work, but users will be presented with the eval error above and have to opt-in.
If you are pinged as one of the maintainers of such package, you can do one of the following:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.