Skip to content

Comments

[staging-next] electron_38: fix build with Rust 1.90.0#459376

Merged
leona-ya merged 1 commit intoNixOS:staging-nextfrom
yuyuyureka:electron-38-staging-next
Nov 7, 2025
Merged

[staging-next] electron_38: fix build with Rust 1.90.0#459376
leona-ya merged 1 commit intoNixOS:staging-nextfrom
yuyuyureka:electron-38-staging-next

Conversation

@yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Nov 7, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@yuyuyureka yuyuyureka requested a review from yayayayaka November 7, 2025 06:13
@nixpkgs-ci nixpkgs-ci bot requested review from TomaSajt and teutat3s November 7, 2025 06:19
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 7, 2025
@yuyuyureka yuyuyureka mentioned this pull request Nov 7, 2025
Merged
24 tasks
teutat3s
teutat3s approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 7, 2025
@leona-ya leona-ya added this pull request to the merge queue Nov 7, 2025
yayayayaka
yayayayaka approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 7, 2025
Merged via the queue into NixOS:staging-next with commit 892647f Nov 7, 2025
34 of 38 checks passed
@yuyuyureka yuyuyureka mentioned this pull request Nov 7, 2025
Closed
3 tasks
@yuyuyureka yuyuyureka deleted the electron-38-staging-next branch November 7, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s teutat3s approved these changes

@leona-ya leona-ya leona-ya approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuyuyureka @teutat3s @leona-ya @yayayayaka