Skip to content

Comments

electron-chromedriver_35: remove#460303

Merged
yuyuyureka merged 1 commit intoNixOS:masterfrom
teutat3s:electron-35-cleanup
Nov 10, 2025
Merged

electron-chromedriver_35: remove#460303
yuyuyureka merged 1 commit intoNixOS:masterfrom
teutat3s:electron-35-cleanup

Conversation

@teutat3s
Copy link
Member

This was overlooked in 933d435, part of #458485.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 10, 2025
@teutat3s teutat3s force-pushed the electron-35-cleanup branch from b2c4afc to 5d63205 Compare November 10, 2025 10:34
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't forget to remove the hashes chromedriver/info.json.

@teutat3s teutat3s force-pushed the electron-35-cleanup branch from 5d63205 to 034ceb0 Compare November 10, 2025 12:39
@yuyuyureka yuyuyureka added this pull request to the merge queue Nov 10, 2025
Merged via the queue into NixOS:master with commit 06b28f9 Nov 10, 2025
26 of 29 checks passed
@teutat3s teutat3s deleted the electron-35-cleanup branch November 11, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants