bitwarden-desktop: backport electron_37 update#458491
Merged
yuyuyureka merged 1 commit intoNixOS:masterfrom Nov 5, 2025
Merged
bitwarden-desktop: backport electron_37 update#458491yuyuyureka merged 1 commit intoNixOS:masterfrom
yuyuyureka merged 1 commit intoNixOS:masterfrom
Conversation
As electron_36 is EOL and will soon be marked insecure.
24 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
SuperSandro2000
approved these changes
Nov 5, 2025
| ./dont-use-platform-triple.patch | ||
|
|
||
| (fetchpatch2 { | ||
| url = "https://github.com/bitwarden/clients/commit/cd56d01894c38cf046a7e44dcacc7e0ff2aa2a37.patch?full_index=1"; |
Member
There was a problem hiding this comment.
Lets hope not some other patches are required to make this update work
nixpkgs-ci
bot
added
12.approvals: 1
Member
Author
|
I did my usual manual testing and all seemed well.On Nov 5, 2025, at 10:36, Sandro ***@***.***> wrote:
@SuperSandro2000 approved this pull request.
In pkgs/by-name/bi/bitwarden-desktop/package.nix:
@@ -55,6 +56,11 @@ buildNpmPackage' rec {
./skip-afterpack-and-aftersign.patch
# since out arch doesn't match upstream, we'll generate and use desktop_napi.node instead of desktop_napi.${platform}-${arch}.node
./dont-use-platform-triple.patch
+
+ (fetchpatch2 {
+ url = "https://github.com/bitwarden/clients/commit/cd56d01894c38cf046a7e44dcacc7e0ff2aa2a37.patch?full_index=1";
Lets hope not some other patches are required to make this update work
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As electron_36 is EOL and will soon be marked insecure (see #458485).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.