Skip to content

Comments

[25.05] electron{,-bin,-chromedriver}: 35 -> 37#445475

Merged
yayayayaka merged 2 commits intoNixOS:release-25.05from
teutat3s:backport-422425-to-release-25.05
Oct 6, 2025
Merged

[25.05] electron{,-bin,-chromedriver}: 35 -> 37#445475
yayayayaka merged 2 commits intoNixOS:release-25.05from
teutat3s:backport-422425-to-release-25.05

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Sep 23, 2025

Manual backport of #422425.

Bumps default electron version to 37, because 35 is EOL. Although this is a potentially breaking change, we did this previously because of the security implications. electron_37 will go EOL just after 25.05 on 2026-01-13.

See also:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 4.workflow: backport This targets a stable branch labels Sep 23, 2025
@teutat3s
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445475
Commit: d8b0c67b9248ff811172311f01b5f75872e16891


x86_64-linux

❌ 4 packages failed to build:
  • cherry-studio
  • ddm
  • gfn-electron
  • yandex-music
✅ 75 packages built:
  • affine-bin
  • antares
  • antimatter-dimensions
  • anytype
  • bilibili
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • bs-manager
  • camunda-modeler
  • caprine
  • chatd
  • drawio
  • drawio-headless
  • equibop
  • fcast-receiver
  • flaci
  • follow
  • freetube
  • gdlauncher-carbon
  • gitify
  • goofcord
  • google-chat-linux
  • headset
  • httptoolkit
  • itch
  • ivpn-ui
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kopia-ui
  • kuro
  • legcord
  • logseq
  • marktext
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • openfortivpn-webview
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • python313Packages.mkdocs-drawio-exporter
  • python313Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • voicevox
  • webtorrent_desktop
  • youtube-music
  • ytdownloader
  • ytmdesktop
  • zap-chip-gui
  • zepp-simulator

Error logs: `x86_64-linux`
cherry-studio
../../out/renderer/assets/wolfram-WfoEoTIe.js                                263.90 kB
../../out/renderer/assets/wasm-DDgzZJey.js                                   622.45 kB
../../out/renderer/assets/cpp-CRU8Scjr.js                                    632.01 kB
../../out/renderer/assets/emacs-lisp-Dxpoxoge.js                             782.12 kB
../../out/renderer/assets/index-DlpMadUm.js                                3,008.30 kB
../../out/renderer/assets/HomeWindow-DiF2Olfb.js                          11,561.50 kB
✓ built in 1m 10s
  • electron-builder  version=26.0.15 os=6.12.48
  • loaded configuration  file=/build/source/electron-builder.yml
  • writing effective config  file=dist/builder-effective-config.yaml
  • executing @electron/rebuild  electronVersion=37.5.1 arch=x64 buildFromSource=false appDir=./
  • installing native dependencies  arch=x64
  • preparing       moduleName=registry-js arch=x64
  ⨯ Could not detect abi for version 37.5.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron  failedTask=build stackTrace=Error: Could not detect abi for version 37.5.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (/build/source/node_modules/node-abi/index.js:39:9)
    at get ABI (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:89:39)
    at PrebuildInstall.prebuiltModuleExists (/build/source/node_modules/@electron/rebuild/lib/module-type/prebuild-install.js:61:179)
    at ModuleRebuilder.prebuildInstallNativeModuleExists (/build/source/node_modules/@electron/rebuild/lib/module-rebuilder.js:70:37)
    at Rebuilder.rebuildModuleAt (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:146:35)
    at async Rebuilder.rebuild (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:111:17)
gfn-electron
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
  • electron-builder  version=25.1.8 os=6.12.48
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • executing @electron/rebuild  electronVersion=37.5.1 arch=x64 buildFromSource=false appDir=./
  • installing native dependencies  arch=x64
  • preparing       moduleName=register-scheme arch=x64
  ⨯ Could not detect abi for version 37.5.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron  failedTask=build stackTrace=Error: Could not detect abi for version 37.5.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (/build/source/node_modules/node-abi/index.js:39:9)
    at get ABI (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:89:39)
    at PrebuildInstall.prebuiltModuleExists (/build/source/node_modules/@electron/rebuild/lib/module-type/prebuild-install.js:59:179)
    at ModuleRebuilder.prebuildInstallNativeModuleExists (/build/source/node_modules/@electron/rebuild/lib/module-rebuilder.js:70:37)
    at Rebuilder.rebuildModuleAt (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:143:35)
    at async Rebuilder.rebuild (/build/source/node_modules/@electron/rebuild/lib/rebuild.js:115:17)

It does not build with newer releases of electron yet.

(cherry picked from commit 2a7784d)
@teutat3s
Copy link
Member Author

cherry-studio and gfn-electron are now fixed, build failures of ddm and yandex-music are not related to this PR.

@yayayayaka yayayayaka added this pull request to the merge queue Oct 6, 2025
Merged via the queue into NixOS:release-25.05 with commit 20c4598 Oct 6, 2025
29 of 31 checks passed
@teutat3s teutat3s deleted the backport-422425-to-release-25.05 branch October 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants