joplin-desktop: use electron_36#442657
Conversation
ThanePatrol
left a comment
There was a problem hiding this comment.
Haven't seen build results but it looks like you built it so lgtm :)
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-442657-to-release-25.05 origin/release-25.05
cd .worktree/backport-442657-to-release-25.05
git switch --create backport-442657-to-release-25.05
git cherry-pick -x 5f619c0c3ccbc17946cc117599d26c2e1b829588 |
|
Can't be backported because all of the recent commits haven't been either. On the a) backport everything to I think b would be best, what do you think @pyrox0? I can take care of it then. |
|
I'd prefer A, but if B makes your life easier then that's okay with me as well. Would it be possible to skip bumping the package and just bump the electron bin version it uses? Then we wouldn't have to mark insecure but wouldn't risk breaking changes for joplin users either. |
|
Hmm, I think just using a newer Electron won't work, because the app is compiled against a specific version. I could however try backporting the source build without bumping the package version. If that turns out not to be trivial, I would rather mark the package as insecure tho. Is it okay to ping you for a review on a follow up PR? :) |
|
pinging me would be A-OK! |
Electron 35 is EOL and being deprecated in nixpkgs.
Upstream currently still uses v35 in the latest stable release, next one should use v37.
A bug when using Electron 37 was reported: #440567
Using Electron 36, the bug does not occur according to my tests, so I think it's best to update to this version for now.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.