Skip to content

gridtracker2: 2.250820.0 -> 2.250914.1#446675

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
Cryolitia-Forks:gridtracker2
Sep 29, 2025
Merged

gridtracker2: 2.250820.0 -> 2.250914.1#446675
pyrox0 merged 1 commit intoNixOS:masterfrom
Cryolitia-Forks:gridtracker2

Conversation

@Cryolitia
Copy link
Member

@Cryolitia Cryolitia commented Sep 27, 2025

The runtimeInputs seems not needed. It's electron's dependency but not directly gridtracker2's.

Due to [1], update electron to newest. LGTM.

  1. electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL #442413

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Cryolitia Cryolitia changed the title gridtracker2: 2.250820.0 -> 2.250820.0 gridtracker2: 2.250820.0 -> 2.250914.1 Sep 27, 2025
The runtimeInputs seems not needed. It's electron's dependency but not directly gridtracker2's.

Due to [1], update electron to newest. LGTM.

1. NixOS#442413

Signed-off-by: Cryolitia PukNgae <Cryolitia@gmail.com>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 27, 2025
@pyrox0
Copy link
Member

pyrox0 commented Sep 27, 2025

Upstream has a package-lock.json file in their repo, why aren't we using it?

@Cryolitia
Copy link
Member Author

Upstream has a package-lock.json file in their repo, why aren't we using it?

image

The package-lock.json and package.json havn't being sync.

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux, seems to work fine.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 29, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Sep 29, 2025
Merged via the queue into NixOS:master with commit 2e62a59 Sep 29, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants