Skip to content

[25.05] electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL#445467

Merged
leona-ya merged 2 commits intoNixOS:release-25.05from
teutat3s:backport-442413-to-release-25.05
Oct 10, 2025
Merged

[25.05] electron_35-bin: mark as insecure because it's EOL; electron-source.electron_35: remove as it's EOL#445467
leona-ya merged 2 commits intoNixOS:release-25.05from
teutat3s:backport-442413-to-release-25.05

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Sep 23, 2025 •
edited by leona-ya
Loading

Manual backport of #442413.

Note that electron still points to electron_35 on 25.05, we should bump the default electron version before merging this.

Backport PRs of dependent packages:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s marked this pull request as draft September 23, 2025 09:12
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 4.workflow: backport This targets a stable branch labels Sep 23, 2025
This was referenced Sep 23, 2025
Merged
Merged
@teutat3s teutat3s added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 29, 2025
This was referenced Sep 30, 2025
Merged
Merged
Merged
Merged
Merged
@teutat3s teutat3s marked this pull request as ready for review September 30, 2025 17:05
@teutat3s
Copy link
Member Author

teutat3s commented Sep 30, 2025

This is now ready for review. I would like to merge this together with #445475.

@emilylange emilylange mentioned this pull request Oct 2, 2025
Merged
13 tasks
@teutat3s teutat3s force-pushed the backport-442413-to-release-25.05 branch from a0d3f57 to 875e26c Compare October 8, 2025 10:34
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 8, 2025
@teutat3s
Copy link
Member Author

teutat3s commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445467
Commit: 875e26cb55d8a7967bf4fc0f0647fd6491d2c45a

x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • affine
  • gfn-electron
  • penpot-desktop

@leona-ya leona-ya added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:release-25.05 with commit 7ef649e Oct 10, 2025
32 of 34 checks passed
@teutat3s teutat3s deleted the backport-442413-to-release-25.05 branch October 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teutat3s @leona-ya