Skip to content

Comments

penpot-desktop: 0.13.1 -> 0.18.1#407337

Merged
yayayayaka merged 3 commits intoNixOS:masterfrom
NTBBloodbath:penpot-desktop-0.14.1
Sep 22, 2025
Merged

penpot-desktop: 0.13.1 -> 0.18.1#407337
yayayayaka merged 3 commits intoNixOS:masterfrom
NTBBloodbath:penpot-desktop-0.14.1

Conversation

@NTBBloodbath
Copy link
Contributor

Update to 0.14.1.

penpot-desktop 0.14.0 added support for self-hosting penpot via docker, so I made a wrapper in postFixup to add docker to the penpot-desktop PATH.

Since this update later had a bugfix release (0.14.1), I've made individual commits for both versions to keep the changes atomic.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 15, 2025
@NTBBloodbath NTBBloodbath force-pushed the penpot-desktop-0.14.1 branch from 862a7a4 to eeef419 Compare May 15, 2025 12:19
@pbsds
Copy link
Member

pbsds commented May 28, 2025

is the self-hosting optional? if so i think it is better to not wrap the entrypoint with docker, since some may prefer to use podman or not include docker in their system closure at all

@NTBBloodbath
Copy link
Contributor Author

is the self-hosting optional? if so i think it is better to not wrap the entrypoint with docker, since some may prefer to use podman or not include docker in their system closure at all

Yes, it is optional. I'm not sure anyone can use podman unless heavily patching the source code, although it would be good to be able to remove the dependency on docker if the end user so desires. Do you have any idea what I could do in that case to avoid wrapping? Feel free to point out some docs if required, I would like to learn a little more about Nix :)

@pbsds
Copy link
Member

pbsds commented May 28, 2025

if docker is optional and the program is able to detect when docker is not available in the path and notify the user of this in a way they can act on, then I think it is better to simply not add it to the PATH. This will also benefit non-nixos (i.e. fhs) users

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@nixpkgs-ci nixpkgs-ci bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Sep 21, 2025
@NTBBloodbath NTBBloodbath changed the title penpot-desktop: 0.13.1 -> 0.14.1 penpot-desktop: 0.13.1 -> 0.18.1 Sep 21, 2025
@NTBBloodbath
Copy link
Contributor Author

I've updated penpot-desktop to the latest available version (0.18.1) and removed the postFixup for including docker into the package PATH as suggested.

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux, looking good to me.

@yayayayaka yayayayaka added this pull request to the merge queue Sep 22, 2025
Merged via the queue into NixOS:master with commit 733fead Sep 22, 2025
30 of 32 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Sep 29, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants