penpot-desktop: 0.13.1 -> 0.18.1#407337
Conversation
862a7a4 to
eeef419
Compare
|
is the self-hosting optional? if so i think it is better to not wrap the entrypoint with docker, since some may prefer to use podman or not include docker in their system closure at all |
Yes, it is optional. I'm not sure anyone can use podman unless heavily patching the source code, although it would be good to be able to remove the dependency on docker if the end user so desires. Do you have any idea what I could do in that case to avoid wrapping? Feel free to point out some docs if required, I would like to learn a little more about Nix :) |
|
if docker is optional and the program is able to detect when docker is not available in the path and notify the user of this in a way they can act on, then I think it is better to simply not add it to the PATH. This will also benefit non-nixos (i.e. fhs) users |
6c56f11 to
d64e2ad
Compare
|
I've updated penpot-desktop to the latest available version (0.18.1) and removed the |
yayayayaka
left a comment
There was a problem hiding this comment.
Tested on x86_64-linux, looking good to me.
|
Successfully created backport PR for |
Update to
0.14.1.penpot-desktop 0.14.0 added support for self-hosting penpot via docker, so I made a wrapper in postFixup to add docker to the penpot-desktop PATH.
Since this update later had a bugfix release (
0.14.1), I've made individual commits for both versions to keep the changes atomic.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.