Skip to content

ocaml-ng: remove __attrsFailEvaluation#340337

Merged
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/ocaml
Nov 1, 2024
Merged

ocaml-ng: remove __attrsFailEvaluation#340337
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/ocaml

Conversation

@philiptaron
Copy link
Contributor

Motivation for changes

Remove an instance of __attrsFailEvaluation.

Previously:

Description of changes

https://gist.github.com/philiptaron/3a5bad8ac3d3c58485f907d4233066c0

The test (nix-build pkgs/test/release/default.nix) continues to pass on x86_64-linux.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 7, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2024
@infinisil infinisil merged commit 1eb9f3d into NixOS:master Nov 1, 2024
@philiptaron philiptaron deleted the __attrsFailEvaluation/ocaml branch November 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants