Skip to content

coqPackages: allow one level of introspection before applying __attrsFailEvaluation#324675

Merged
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/coq
Jul 25, 2024
Merged

coqPackages: allow one level of introspection before applying __attrsFailEvaluation#324675
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/coq

Conversation

@philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/5b9292e9972ec1e18f01fc1cb5e8b77a

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron force-pushed the __attrsFailEvaluation/coq branch from 637b6bb to 4640ede Compare July 4, 2024 21:05
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 4, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 224dedb into NixOS:master Jul 25, 2024
@philiptaron philiptaron deleted the __attrsFailEvaluation/coq branch July 26, 2024 15:59
@philiptaron
Copy link
Contributor Author

I accidentally removed recurseIntoAttrs for coqPackages. @mweinelt fixed it in #330205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants