qt5: remove __attrsFailEvaluation as all attrsets evaluate#324622
Merged
infinisil merged 2 commits intoNixOS:masterfrom Jul 25, 2024
Merged
qt5: remove __attrsFailEvaluation as all attrsets evaluate#324622infinisil merged 2 commits intoNixOS:masterfrom
infinisil merged 2 commits intoNixOS:masterfrom
Conversation
philiptaron
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
as code owners
github-actions
bot
added
the
6.topic: qt/kde
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
changed the title
36 tasks
SuperSandro2000
approved these changes
Jul 5, 2024
infinisil
approved these changes
Jul 25, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
__attrsFailEvaluation#324619The test (
nix-build pkgs/test/release/default.nix) continues to pass.These lines were added in #269356.
New derivations reported: https://gist.github.com/philiptaron/553c4bf5385d6648ac778099bf47977e
Things done
nix-build pkgs/test/release/default.nix