Skip to content

pythonPackages: move __attrsFailEvaluation to allow deeper inspection#324682

Merged
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/python
Jul 26, 2024
Merged

pythonPackages: move __attrsFailEvaluation to allow deeper inspection#324682
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/python

Conversation

@philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/918e9ec33ec9e9eddf6c23639643dbb9

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron requested a review from natsukium as a code owner July 4, 2024 21:51
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 4, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 4, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 29016e9 into NixOS:master Jul 26, 2024
@philiptaron philiptaron deleted the __attrsFailEvaluation/python branch July 26, 2024 15:58
@philiptaron
Copy link
Contributor Author

I accidentally removed recurseIntoAttrs for Python 3.11 and 3.12. @mweinelt fixed it in #330205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants