linuxPackages: remove __attrsFailEvaluation since the attrset evaluates#324688
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jul 27, 2024
Merged
Conversation
36 tasks
infinisil
approved these changes
Jul 26, 2024
Member
infinisil
left a comment
There was a problem hiding this comment.
Needs a rebase, but I tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!
83f3589 to
38ffd73
Compare
Contributor
Author
|
Thanks, rebased. |
Contributor
Author
|
Whew, I didn't erroneously remove any |
Member
|
Can confirm, master works :P |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
__attrsFailEvaluation#324619The test (
nix-build pkgs/test/release/default.nix) continues to pass.These lines were added in #269356.
New derivations reported: https://gist.github.com/philiptaron/4db141eb60b787b11a8d413dc52598ab
Things done
nix-build pkgs/test/release/default.nix