pidginPackages: move __attrsFailEvaluation to allow deeper evaluation#323867
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jul 25, 2024
Merged
Conversation
ofborg
bot
added
8.has: clean-up
Contributor
|
Result of |
Contributor
|
Derivation-wise LGTM |
lucasew
approved these changes
Jul 1, 2024
36 tasks
The test (`nix-build pkgs/test/release/default.nix`) continues to pass.
philiptaron
force-pushed
the
__attrsFailEvaluation/pidginPackages
branch
from
559c087 to
3abc5f7
Compare
wegank
removed
the
12.approvals: 1
infinisil
approved these changes
Jul 25, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!
5 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The test (
nix-build pkgs/test/release/default.nix) test continues to pass.These lines were added in #269356.
New derivations reported:
Things done
nix-build pkgs/test/release/default.nix