Skip to content

dockerTools: remove __attrsFailEvaluation#323860

Merged
lf- merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/dockerTools
Jul 1, 2024
Merged

dockerTools: remove __attrsFailEvaluation#323860
lf- merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/dockerTools

Conversation

@philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass without this preventative measure.

This line was added in #269356.

It adds these paths: https://gist.github.com/philiptaron/78df3a1b0f9d245c25986552bd1eff26

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

The test (`nix-build pkgs/test/release/default.nix`) continues to pass without this preventative measure.
@philiptaron philiptaron requested a review from lf- July 1, 2024 18:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 1, 2024
@lf- lf- merged commit f3ff4d1 into NixOS:master Jul 1, 2024
@lf-
Copy link
Member

lf- commented Jul 1, 2024

hmmm i hope i didn't screw up here, this isn't a darwin hack right?

@philiptaron
Copy link
Contributor Author

hmmm i hope i didn't screw up here, this isn't a darwin hack right?

Not that I know of... but I didn't test this on Darwin, either. It originates from #269356 which didn't look to make any Darwin-specific eval branches, so I sort of doubt it is.

@philiptaron
Copy link
Contributor Author

Just to follow up: nix-instantiate --eval --system aarch64-darwin --strict --json pkgs/top-level/release-attrpaths-superset.nix -A names completes without error on this branch.

@philiptaron philiptaron deleted the __attrsFailEvaluation/dockerTools branch July 4, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants