nodejs_14: is EOL on 2023-04-30, nodejs_16: goes EOL during 23.05 release#229910
Merged
mweinelt merged 2 commits intoNixOS:masterfrom May 19, 2023
Merged
nodejs_14: is EOL on 2023-04-30, nodejs_16: goes EOL during 23.05 release#229910mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt merged 2 commits intoNixOS:masterfrom
Conversation
teutat3s
approved these changes
May 4, 2023
ofborg
bot
added
10.rebuild-darwin: 0
12 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Head's up. Your package is using And remember that there is now
|
Member
|
thanks for ping. I will take care of elm modules. |
12 tasks
12 tasks
12 tasks
Member
|
We might have to pull nodejs_16 as well, given that it EOLS in 4 months. cc @turboMaCk |
12 tasks
mweinelt
added
the
12.approvals: 1
hyshka
added a commit
to hyshka/nixpkgs
that referenced
this pull request
May 6, 2023
Node.js 14 is EOL. NixOS#229910 Package changelog: https://github.com/psi-4ward/psitransfer/releases Package compare v2.0.1...v2.1.2: psi-4ward/psitransfer@v2.0.1...v2.1.2
12 tasks
12 tasks
12 tasks
turboMaCk
added a commit
to turboMaCk/nixpkgs
that referenced
this pull request
May 7, 2023
Related to issue NixOS#229910 This bumps nodejs to 18 since 16 is soon to EOL.
12 tasks
selmison
pushed a commit
to selmison/nixpkgs
that referenced
this pull request
May 8, 2023
Node.js 14 is EOL. NixOS#229910 Package changelog: https://github.com/psi-4ward/psitransfer/releases Package compare v2.0.1...v2.1.2: psi-4ward/psitransfer@v2.0.1...v2.1.2
because it will reach its EOL 2023-09-11, before the EOL of NixOS 23.05
mweinelt
changed the title
This was referenced May 19, 2023
Merged
This was referenced May 20, 2023
amarshall
added a commit
to amarshall/nixpkgs
that referenced
this pull request
May 20, 2023
- Backport patch from Bitwarden master to achieve this as they have done (unreleased) upgrade 16→18, and have several other changes along with it. We want this now because Node 16 is being marked insecure soon for NixOS 23.05; see NixOS#229910. - These changes should be in the next release in a few weeks - `npm bin` no longer exists, use `npm exec` instead
This was referenced May 21, 2023
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
May 21, 2023
Part of NixOS#229910. Unfortunately this is a little hacky because upstream doesn't intend to support it for 2.5, but only for 3.0 which isn't out yet, however nodejs-16 will get out of maintenance during the support-span of NixOS 23.05[1]. The only breaking change is that `extract-files` uses a deprecated way of exposing modules, I went through the list of other breaking changes in v17 and v18[2][3] and couldn't spot any usage of removed features, also local testing didn't reveal further issues. Unfortunately fixing that breakage turned out to be non-trivial. Currently, `extract-files@9.0.0` is used with the problematic portions in its `package.json`, however it's only a transitive dependency of `@graphql-tools/url-loader` & `apollo-upload-client`. Unfortunately, the versions of that in use require v9 and don't work with a newer version of `extract-files` with the problem fixed[4]. Also, upgrading the dependencies in question is not a feasible option because `graphql-tools` was split up into multiple smaller packages in v8 and also some of the APIs in use in `wiki.js` were dropped there[5], so this would also be very time-consuming and non-trivial to fix. Since this was the only issue, I decided to go down the hacky route and patch the problem in `package.json` of `extract-files` manually during our `patchPhase`. [1] requarks/wiki#6388 [2] https://nodejs.org/en/blog/release/v17.0.0 [3] https://nodejs.org/en/blog/release/v18.0.0 [4] Upon local testing, this broke with the following error: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './public/extractFiles' is not defined by "exports" in /wiki/node_modules/extract-files/package.json [5] For instance `SchemaDirectiveVisitor` in `server/graph/directives/auth`. (cherry picked from commit 577ffe7)
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
May 21, 2023
Part of NixOS#229910. Upstream uses `node:current-alpine` to build their images[1], so newer nodejs versions shouldn't be a problem. [1] https://github.com/Ylianst/MeshCentral/blob/1.1.5/docker/Dockerfile (cherry picked from commit d9f9708)
12 tasks
midchildan
added a commit
to midchildan/nixpkgs
that referenced
this pull request
May 21, 2023
Relates to NixOS#229910
12 tasks
midchildan
added a commit
to midchildan/nixpkgs
that referenced
this pull request
May 24, 2023
Relates to NixOS#229910.
lunik1
added a commit
to lunik1/flakelight-bug-mwe
that referenced
this pull request
Feb 27, 2026
NixOS/nixpkgs#229910 marked node 16 as insecure, so now all nodePackages fail to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)