Skip to content

elmPackages: Use nodejs 18#230543

Merged
turboMaCk merged 1 commit intoNixOS:masterfrom
turboMaCk:elm-node-18
May 8, 2023
Merged

elmPackages: Use nodejs 18#230543
turboMaCk merged 1 commit intoNixOS:masterfrom
turboMaCk:elm-node-18

Conversation

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented May 7, 2023

Related to issue #229910
This bumps nodejs to 18 since 16 is soon to EOL.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@turboMaCk
elmPackages: Use nodejs 18
4e8cbf9 
Related to issue NixOS#229910
This bumps nodejs to 18 since 16 is soon to EOL.
@ofborg ofborg bot requested a review from jali-clarke May 7, 2023 17:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2023
@mweinelt mweinelt mentioned this pull request May 7, 2023
Merged
12 tasks
@turboMaCk turboMaCk merged commit 7da61c1 into NixOS:master May 8, 2023
@turboMaCk turboMaCk deleted the elm-node-18 branch May 8, 2023 18:02
@r-vdp r-vdp mentioned this pull request May 21, 2023
Merged
12 tasks
r-vdp added a commit to r-vdp/nixpkgs that referenced this pull request May 21, 2023
@r-vdp
elmPackages: nodejs_14 -> nodejs_18.
714c4d3 
Follow-up to NixOS#230543, we were still using nodejs_14 for some packages.

I also turned the node dependency into an input, so that it can be
overriden, which is handy for local testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jali-clarke jali-clarke Awaiting requested review from jali-clarke

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@turboMaCk