Skip to content

isso: 0.12.6.2 -> 0.13.0#233399

Merged
RaitoBezarius merged 1 commit intomasterfrom
update/isso
May 22, 2023
Merged

isso: 0.12.6.2 -> 0.13.0#233399
RaitoBezarius merged 1 commit intomasterfrom
update/isso

Conversation

@RaitoBezarius
Copy link
Member

Description of changes

This uses buildNpmPackage now and Node.js 20.
Also, packages the HTML documentation in a new output.

https://isso-comments.de/news/#isso-version-0-13-0-released

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@RaitoBezarius
Copy link
Member Author

Contributes towards #229910.

@ofborg ofborg bot requested a review from fgaz May 22, 2023 12:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 22, 2023
@RaitoBezarius RaitoBezarius mentioned this pull request May 22, 2023
12 tasks
Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like using fetchNpmDeps is what you are looking for here :)

@RaitoBezarius RaitoBezarius force-pushed the update/isso branch 2 times, most recently from e34619e to ea0f862 Compare May 22, 2023 16:34
@JulienMalka
Copy link
Member

Result of nixpkgs-review pr 233399 run on x86_64-linux 1

3 packages built:
  • isso
  • isso.dist
  • isso.doc

Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥖

This uses `buildNpmPackage` now and Node.js 20.
Also, packages the HTML documentation in a new output.

https://isso-comments.de/news/#isso-version-0-13-0-released
@RaitoBezarius
Copy link
Member Author

Result of nixpkgs-review pr 233399 run on x86_64-linux 1

3 packages built:
  • isso
  • isso.dist
  • isso.doc

@RaitoBezarius RaitoBezarius merged commit 4a22f84 into master May 22, 2023
@SuperSandro2000 SuperSandro2000 deleted the update/isso branch May 22, 2023 19:09
@fgaz fgaz mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants