Skip to content

base16-builder: regenarate with nodejs_18#231069

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
natsukium:base16-builder/use-nodejs-18
May 10, 2023
Merged

base16-builder: regenarate with nodejs_18#231069
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
natsukium:base16-builder/use-nodejs-18

Conversation

@natsukium
Copy link
Member

Description of changes

ZHF: #230712
https://hydra.nixos.org/build/218113978

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 10, 2023
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preferred way to package nodejs programs is now to use buildNpmPackage, which is easier to use and does not rely on codegen.

@SuperSandro2000 SuperSandro2000 merged commit bcd2558 into NixOS:master May 10, 2023
@natsukium natsukium deleted the base16-builder/use-nodejs-18 branch May 21, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants