ntfy-sh: build node dependencies with nodejs_18#230188
Merged
lilyinstarlight merged 1 commit intoNixOS:masterfrom May 12, 2023
Merged
ntfy-sh: build node dependencies with nodejs_18#230188lilyinstarlight merged 1 commit intoNixOS:masterfrom
lilyinstarlight merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
11.by: package-maintainer
teutat3s
requested changes
May 6, 2023
arjan-s
force-pushed
the
ntfy-fix-node14
branch
2 times, most recently
from
45a5786 to
e81626d
Compare
12 tasks
teutat3s
approved these changes
May 8, 2023
Member
|
Result of 1 package built:
|
ofborg
bot
added
10.rebuild-darwin: 0
lilyinstarlight
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Build NodeJS dependencies with NodeJS 18 instead of 14, which is EOL (see #229910).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)