Skip to content

epgstation: use node18 + other fixes#233053

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
midchildan:chore/epgstation/node18
May 22, 2023
Merged

epgstation: use node18 + other fixes#233053
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
midchildan:chore/epgstation/node18

Conversation

@midchildan
Copy link
Member

@midchildan midchildan commented May 20, 2023

Description of changes

Relates to #229910, #186582, and #187120.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 20, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 20, 2023
@midchildan midchildan changed the title chore: use node18 + other fixes epgstation: use node18 + other fixes May 20, 2023
@midchildan midchildan force-pushed the chore/epgstation/node18 branch from f50225b to f5d7d17 Compare May 20, 2023 20:43
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 20, 2023
This was referenced May 20, 2023
Closed
Merged
@midchildan midchildan force-pushed the chore/epgstation/node18 branch from f5d7d17 to b6cd418 Compare May 21, 2023 05:29
@midchildan
Copy link
Member Author

midchildan commented May 21, 2023

I pushed a fix for #187120 (comment), replacing ffmpeg-full with ffmpeg-headless.

@lilyinstarlight lilyinstarlight mentioned this pull request May 21, 2023
Merged
12 tasks
SuperSandro2000
SuperSandro2000 reviewed May 21, 2023
View reviewed changes
@midchildan midchildan force-pushed the chore/epgstation/node18 branch 2 times, most recently from 9a403a3 to c74d7ee Compare May 21, 2023 16:02
@midchildan midchildan force-pushed the chore/epgstation/node18 branch from c74d7ee to 94eb60a Compare May 21, 2023 20:24
@SuperSandro2000 SuperSandro2000 merged commit 493c6d8 into NixOS:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@midchildan @SuperSandro2000